Skip to content

syncing project settings#2258

Merged
david-driscoll merged 1 commit into
mainfrom
sync-with
Jul 1, 2026
Merged

syncing project settings#2258
david-driscoll merged 1 commit into
mainfrom
sync-with

Conversation

@david-driscoll

Copy link
Copy Markdown
Member

No description provided.

@david-driscoll david-driscoll enabled auto-merge July 1, 2026 19:57
@codacy-production

Copy link
Copy Markdown

Not up to standards ⛔

🔴 Issues 1 critical · 2 high · 2 medium

Alerts:
⚠ 5 issues (≤ 0 issues of at least minor severity)

Results:
5 new issues

Category Results
Compatibility 2 medium
ErrorProne 1 critical
Security 2 high

View in Codacy

🟢 Metrics 0 complexity · -2 duplication

Metric Results
Complexity 0
Duplication -2

View in Codacy

AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.

Run reviewer

TIP This summary will be updated as you push new changes.

@github-actions github-actions Bot added this to the v10.0.6 milestone Jul 1, 2026
@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown

Test Results

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit cf5177c. ± Comparison against base commit 74bb044.

@codacy-production codacy-production Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces significant architectural changes, including a migration of the documentation engine to Astro/Starlight and the enablement of Central Package Version Management (CPVM). However, the Codacy analysis indicates the project is currently not up to standards.

The most critical issue is the enablement of CPVM without the inclusion of the required Directory.Packages.props file, which will result in immediate build failures. Additionally, several extension methods in the testing utility lack null checks, posing a risk of runtime exceptions. There is also a lack of a PR description for these substantial changes, and the suppression of critical compiler diagnostics (CS1061) in the linter configuration should be reconsidered to avoid masking breaking changes.

About this PR

  • The PR provides no description despite significant architectural changes, such as replacing the documentation engine and altering the CI security model. Please provide context for these changes to assist in long-term maintainability.

Test suggestions

  • Verify that 'mise run docs:build' correctly executes the Astro build command in the docs workspace
  • Confirm autofix.ci workflow triggers on 'pull_request' and executes 'hk fix'
  • Ensure .NET builds include the Readme.md file in the package path as defined in Directory.Build.props
  • Validate that DryIoc resolver extensions correctly preserve existing resolvers using the C# 12 spread operator

TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback

return rules.WithUnknownServiceResolvers(
( rules.UnknownServiceResolvers ?? Array.Empty<Rules.UnknownServiceResolver>() ).ToImmutableList().Add(
[
.. ( rules.UnknownServiceResolvers ?? [] ),

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 HIGH RISK

Add a null check at the beginning of the method to ensure that the 'rules' object is valid before it is used. Consider adding 'ArgumentNullException.ThrowIfNull(rules);' to the beginning of the 'WithTestLoggerResolver' and 'WithUndefinedTestDependenciesResolver' methods.

Comment thread Directory.Build.props
<NuGetAuditMode>all</NuGetAuditMode>
<NuGetAuditLevel>moderate</NuGetAuditLevel>
<SolutionDir>$(MSBuildThisFileDirectory)</SolutionDir>
<ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 HIGH RISK

Enabling Central Package Version Management (CPVM) requires a Directory.Packages.props file at the root of the repository. Without this file, NuGet will fail to resolve dependencies, breaking the build for all projects in the solution.

@david-driscoll david-driscoll disabled auto-merge July 1, 2026 21:14
@david-driscoll david-driscoll merged commit 4a494b8 into main Jul 1, 2026
6 of 9 checks passed
@david-driscoll david-driscoll deleted the sync-with branch July 1, 2026 21:14
@github-actions github-actions Bot added the ✨ mysterious We forgot to label this label Jul 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨ mysterious We forgot to label this

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant