Update vstest monorepo (major)#3008
Conversation
Test Results760 tests ±0 756 ✅ ±0 4m 5s ⏱️ -1s Results for commit 9ceb116. ± Comparison against base commit 7ad0cdd. This pull request removes 7 and adds 7 tests. Note that renamed tests count towards both. |
SummarySummary
CoverageAnalyzers.Tests - 96.9%
AspNetCore.FluentValidation.OpenApi.Tests - 46%
AspNetCore.Tests - 23.8%
Extensions.Tests - 88.8%
Metadata.Tests - 28.6%
Rocket.Surgery.LaunchPad.Analyzers - 90.1%
Rocket.Surgery.LaunchPad.AspNetCore - 49.7%
Rocket.Surgery.LaunchPad.AspNetCore.FluentValidation.OpenApi - 62.3%
Rocket.Surgery.LaunchPad.AspNetCore.Testing - 47.2%
Rocket.Surgery.LaunchPad.EntityFramework - 29.3%
Rocket.Surgery.LaunchPad.Foundation - 43.3%
Rocket.Surgery.LaunchPad.Foundation.NewtonsoftJson - 64.4%
Rocket.Surgery.LaunchPad.Grpc - 41.1%
Rocket.Surgery.LaunchPad.Hosting - 48%
Rocket.Surgery.LaunchPad.Mapping - 38.3%
Rocket.Surgery.LaunchPad.Metadata - 49.7%
Rocket.Surgery.LaunchPad.Primitives - 71.6%
Rocket.Surgery.LaunchPad.Serilog - 60%
Rocket.Surgery.LaunchPad.Spatial - 59.3%
Rocket.Surgery.LaunchPad.Spatial.NewtonsoftJson - 37.2%
Rocket.Surgery.LaunchPad.StrawberryShake - 47.8%
Rocket.Surgery.LaunchPad.StrawberryShake.Spatial - 8.8%
Rocket.Surgery.LaunchPad.Telemetry - 20.8%
Rocket.Surgery.LaunchPad.Testing - 13.2%
Sample.BlazorServer - 5.2%
Sample.BlazorServer.Tests - 29%
Sample.BlazorWasm.Tests - 15.7%
Sample.Classic.Restful - 3.5%
Sample.Classic.Restful.Tests - 41%
Sample.Command.Tests - 16.3%
Sample.Core - 75.8%
Sample.Core.Tests - 55.3%
Sample.Graphql.Tests - 58.9%
Sample.Grpc - 73.2%
Sample.Grpc.Tests - 41.7%
Sample.Minimal - 16.2%
Sample.Minimal.Tests - 28%
Sample.Pages - 5.6%
Sample.Pages.Tests - 29.6%
Sample.Restful - 4%
Sample.Restful.Tests - 40%
Sample.Worker.Tests - 16.3%
|
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a major version upgrade for Microsoft.CodeCoverage but fails to maintain version parity with Microsoft.NET.Test.Sdk. Although Codacy reports the PR as 'Up to Standards', the logical mismatch between these core test platform components is a high-risk change that could cause runtime failures in CI pipelines.
There is an implementation gap regarding acceptance criteria: a 'vstest monorepo' update should generally encompass all related platform packages to ensure compatibility. The absence of regression testing for this major version jump is a primary concern.
About this PR
- The PR title indicates an update to the 'vstest monorepo', yet only
Microsoft.CodeCoveragehas been updated to version 18.6.0.Microsoft.NET.Test.Sdkremains at version 17.14.1. Mixing major versions of these coupled components often leads toMissingMethodExceptionor failures in test data collectors.
Test suggestions
- Verify that test execution and coverage collection remain functional under the new major version of Microsoft.CodeCoverage.
- Verify compatibility between Microsoft.CodeCoverage 18.6.0 and Microsoft.NET.Test.Sdk 17.14.1.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify that test execution and coverage collection remain functional under the new major version of Microsoft.CodeCoverage.
2. Verify compatibility between Microsoft.CodeCoverage 18.6.0 and Microsoft.NET.Test.Sdk 17.14.1.
Low confidence findings
- This major version upgrade lacks evidence of regression testing or compatibility verification. Ensure that the removal of legacy features in the 18.x branch does not impact your current test execution environment.
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
| <PackageVersion Include="Alba" Version="8.2.1" /> | ||
| <PackageVersion Include="Bogus" Version="35.6.5" /> | ||
| <PackageVersion Include="Microsoft.CodeCoverage" Version="17.14.1" /> | ||
| <PackageVersion Include="Microsoft.CodeCoverage" Version="18.6.0" /> |
There was a problem hiding this comment.
🟡 MEDIUM RISK
Updating Microsoft.CodeCoverage to 18.6.0 while leaving Microsoft.NET.Test.Sdk at 17.14.1 (line 164) introduces a version mismatch. These packages are part of the same suite and should be kept in sync to ensure runtime compatibility.
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
This PR contains the following updates:
17.14.1→18.6.0Release Notes
microsoft/vstest (Microsoft.CodeCoverage)
v18.6.0What's Changed
Changes to tests and infra
Full Changelog: microsoft/vstest@v18.5.1...v18.6.0
v18.5.1What's Changed
Full Changelog: microsoft/vstest@v18.5.0...v18.5.1
v18.5.0What's Changed
Full Changelog: microsoft/vstest@v18.4.0...v18.5.0
v18.4.0What's Changed
Add LoongArch64 support by @stdmnpkg in #15359
Refactor Condition evaluation by @Youssef1313 in #15357
Adding info on extensions points part 1 by @nohwnd in #15360
Add option to ask for uploading code QL before the standard window ends by @nohwnd in #15373
Update runtime versions by @nohwnd in #15372
Fix .NET 10 regression for traits by @Youssef1313 in #15370
Update target frameworks to net10.0 and net11.0 by @dotnet-maestro[bot] in #15349
Fix names in pipeline matrix so we don't have to align them by @nohwnd in #15365
Update SECURITY.md by @Youssef1313 in #15342
New Contributors
Full Changelog: microsoft/vstest@v18.3.0...v18.4.0
v18.3.0What's Changed
Internal fixes and updates
New Contributors
v18.0.1What's Changed
Fixing an issue with loading covrun64.dll on systems that have .NET 10 SDK installed: https://learn.microsoft.com/en-us/dotnet/core/compatibility/sdk/10.0/code-coverage-dynamic-native-instrumentation
Internal changes
Full Changelog: microsoft/vstest@v18.0.0...v18.0.1
v18.0.0What's Changed
Internal fixes and updates
New Contributors
Full Changelog: microsoft/vstest@v17.14.1...v18.0.0
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.