Update mediatr (major)#3005
Conversation
Test Results760 tests ±0 754 ✅ - 2 4m 4s ⏱️ ±0s For more details on these failures, see this check. Results for commit b95d2fa. ± Comparison against base commit 7ad0cdd. This pull request removes 7 and adds 7 tests. Note that renamed tests count towards both. |
SummarySummary
CoverageAnalyzers.Tests - 96.9%
AspNetCore.FluentValidation.OpenApi.Tests - 46%
AspNetCore.Tests - 23.8%
Extensions.Tests - 88.8%
Metadata.Tests - 28.6%
Rocket.Surgery.LaunchPad.Analyzers - 90.1%
Rocket.Surgery.LaunchPad.AspNetCore - 49.7%
Rocket.Surgery.LaunchPad.AspNetCore.FluentValidation.OpenApi - 62.3%
Rocket.Surgery.LaunchPad.AspNetCore.Testing - 47.2%
Rocket.Surgery.LaunchPad.EntityFramework - 29.3%
Rocket.Surgery.LaunchPad.Foundation - 43.3%
Rocket.Surgery.LaunchPad.Foundation.NewtonsoftJson - 64.4%
Rocket.Surgery.LaunchPad.Grpc - 41.1%
Rocket.Surgery.LaunchPad.Hosting - 48%
Rocket.Surgery.LaunchPad.Mapping - 38.3%
Rocket.Surgery.LaunchPad.Metadata - 49.7%
Rocket.Surgery.LaunchPad.Primitives - 71.6%
Rocket.Surgery.LaunchPad.Serilog - 60%
Rocket.Surgery.LaunchPad.Spatial - 59.3%
Rocket.Surgery.LaunchPad.Spatial.NewtonsoftJson - 37.2%
Rocket.Surgery.LaunchPad.StrawberryShake - 47.8%
Rocket.Surgery.LaunchPad.StrawberryShake.Spatial - 8.8%
Rocket.Surgery.LaunchPad.Telemetry - 20.8%
Rocket.Surgery.LaunchPad.Testing - 13.2%
Sample.BlazorServer - 5.2%
Sample.BlazorServer.Tests - 29%
Sample.BlazorWasm.Tests - 15.7%
Sample.Classic.Restful - 3.5%
Sample.Classic.Restful.Tests - 41%
Sample.Command.Tests - 16.3%
Sample.Core - 75.8%
Sample.Core.Tests - 55.3%
Sample.Graphql.Tests - 58.9%
Sample.Grpc - 73.2%
Sample.Grpc.Tests - 41.7%
Sample.Minimal - 16.2%
Sample.Minimal.Tests - 28%
Sample.Pages - 5.6%
Sample.Pages.Tests - 29.6%
Sample.Restful - 4%
Sample.Restful.Tests - 40%
Sample.Worker.Tests - 16.3%
|
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
There was a problem hiding this comment.
Pull Request Overview
This PR updates the MediatR dependency from 12.5.0 to 14.1.0. While the version update itself is straightforward in the configuration files, the PR fails to address a significant breaking change introduced in MediatR v13.0.0.
Starting from version 13, MediatR requires a license key to be configured during service registration. As the current diff only modifies Directory.Packages.props, the application is expected to fail at startup due to the missing cfg.LicenseKey configuration. This must be addressed before merging to ensure service availability.
About this PR
- The upgrade to MediatR 14.1.0 includes breaking changes from v13.0.0 that require explicit license key configuration (e.g.,
cfg.LicenseKey = "..."). Since only the package version was updated, the application will likely fail to initialize. - The PR lacks automated tests to verify that the breaking changes in MediatR v13 and v14 do not impact the application's command/query dispatching or startup sequence.
Test suggestions
- Verify MediatR initialization succeeds with version 14.1.0.
- Verify that a license key is correctly configured as required by MediatR v13+.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify MediatR initialization succeeds with version 14.1.0.
2. Verify that a license key is correctly configured as required by MediatR v13+.
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
|
|
||
|
|
||
| <PackageVersion Include="MediatR" Version="12.5.0" /> | ||
| <PackageVersion Include="MediatR" Version="14.1.0" /> |
There was a problem hiding this comment.
🔴 HIGH RISK
This update to MediatR 14.1.0 includes the v13.0.0 breaking change which requires a license key to be configured. No code changes were found implementing the mandatory LicenseKey property in the MediatR configuration. This is a blocker for application startup.
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
This PR contains the following updates:
12.5.0→14.1.0Release Notes
LuckyPennySoftware/MediatR (MediatR)
v14.1.0What's Changed
New Contributors
Full Changelog: LuckyPennySoftware/MediatR@v14.0.0...v14.1.0
v14.0.0What's Changed
Full Changelog: LuckyPennySoftware/MediatR@v13.1.0...v14.0.0
v13.1.0What's Changed
LightInject,StashBox,Lamarby @jithu7432 in #1137New Contributors
Full Changelog: LuckyPennySoftware/MediatR@v13.0.0...v13.1.0
v13.0.0Full Changelog: LuckyPennySoftware/MediatR@v12.5.0...v13.0.0
To set your license key:
You can obtain your license key at MediatR.io
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.