Update dependency FairyBread to v12#3002
Conversation
Test Results760 tests ±0 756 ✅ ±0 4m 0s ⏱️ -18s Results for commit 4335b4d. ± Comparison against base commit 89d7c0c. This pull request removes 7 and adds 7 tests. Note that renamed tests count towards both. |
SummarySummary
CoverageAnalyzers.Tests - 96.9%
AspNetCore.FluentValidation.OpenApi.Tests - 46%
AspNetCore.Tests - 23.8%
Extensions.Tests - 88.8%
Metadata.Tests - 28.6%
Rocket.Surgery.LaunchPad.Analyzers - 90.1%
Rocket.Surgery.LaunchPad.AspNetCore - 49.7%
Rocket.Surgery.LaunchPad.AspNetCore.FluentValidation.OpenApi - 62.3%
Rocket.Surgery.LaunchPad.AspNetCore.Testing - 47.2%
Rocket.Surgery.LaunchPad.EntityFramework - 29.3%
Rocket.Surgery.LaunchPad.Foundation - 43.3%
Rocket.Surgery.LaunchPad.Foundation.NewtonsoftJson - 64.4%
Rocket.Surgery.LaunchPad.Grpc - 41.1%
Rocket.Surgery.LaunchPad.Hosting - 48%
Rocket.Surgery.LaunchPad.Mapping - 38.3%
Rocket.Surgery.LaunchPad.Metadata - 49.7%
Rocket.Surgery.LaunchPad.Primitives - 71.6%
Rocket.Surgery.LaunchPad.Serilog - 60%
Rocket.Surgery.LaunchPad.Spatial - 59.3%
Rocket.Surgery.LaunchPad.Spatial.NewtonsoftJson - 37.2%
Rocket.Surgery.LaunchPad.StrawberryShake - 47.8%
Rocket.Surgery.LaunchPad.StrawberryShake.Spatial - 8.8%
Rocket.Surgery.LaunchPad.Telemetry - 20.8%
Rocket.Surgery.LaunchPad.Testing - 13.2%
Sample.BlazorServer - 5.2%
Sample.BlazorServer.Tests - 29%
Sample.BlazorWasm.Tests - 15.7%
Sample.Classic.Restful - 3.5%
Sample.Classic.Restful.Tests - 41%
Sample.Command.Tests - 16.3%
Sample.Core - 75.8%
Sample.Core.Tests - 55.3%
Sample.Graphql.Tests - 58.9%
Sample.Grpc - 73.2%
Sample.Grpc.Tests - 41.7%
Sample.Minimal - 16.2%
Sample.Minimal.Tests - 28%
Sample.Pages - 5.6%
Sample.Pages.Tests - 29.6%
Sample.Restful - 4%
Sample.Restful.Tests - 40%
Sample.Worker.Tests - 16.3%
|
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
There was a problem hiding this comment.
Pull Request Overview
Codacy analysis indicates that the pull request is up to standards. However, the update to the FairyBread library introduces breaking changes by dropping support for .NET 6.0, .NET 7.0, and .NET Standard 2.0. As the current change only modifies the central packages file, it is impossible to confirm from the diff whether all consuming projects have been updated to target .NET 8.0 or higher. This represents a significant risk to build stability.
About this PR
- The update to FairyBread v12.0.0 drops support for .NET 6.0, .NET 7.0, and .NET Standard 2.0. It is essential to verify that all consuming projects in this repository target .NET 8.0 or higher to prevent build failures.
Test suggestions
- Verify that all projects consuming the FairyBread package target .NET 8.0 or higher, as v12.0.0 drops support for .NET 6.0 and 7.0.\n- [ ] Verify compatibility with FluentValidation v12.0.0, which is currently used in the project, as FairyBread has bumped its minimum requirement to v11.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify that all projects consuming the FairyBread package target .NET 8.0 or higher, as v12.0.0 drops support for .NET 6.0 and 7.0.\n- [ ] Verify compatibility with FluentValidation v12.0.0, which is currently used in the project, as FairyBread has bumped its minimum requirement to v11.
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
This PR contains the following updates:
11.0.0→12.0.0Release Notes
benmccallum/fairybread (FairyBread)
v12.0.0Adds support for HotChocolate 15.
Breaking changes
netstandard2.0,net6.0andnet7.0, in line with the ChilliCream team also dropping those in HC15.net8.0andnet9.0instead.Thanks for the help, @apereiratl, a new contributor :)
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.