Update roslyn to 5.3.0#2999
Conversation
Test Results760 tests ±0 721 ✅ - 35 3m 56s ⏱️ -22s For more details on these failures, see this check. Results for commit 907d044. ± Comparison against base commit 89d7c0c. This pull request removes 7 and adds 7 tests. Note that renamed tests count towards both. |
SummarySummary
CoverageAnalyzers.Tests - 96.9%
AspNetCore.FluentValidation.OpenApi.Tests - 46%
AspNetCore.Tests - 23.8%
Extensions.Tests - 88.8%
Metadata.Tests - 28.6%
Rocket.Surgery.LaunchPad.Analyzers - 90.1%
Rocket.Surgery.LaunchPad.AspNetCore - 49.7%
Rocket.Surgery.LaunchPad.AspNetCore.FluentValidation.OpenApi - 62.3%
Rocket.Surgery.LaunchPad.AspNetCore.Testing - 47.2%
Rocket.Surgery.LaunchPad.EntityFramework - 29.3%
Rocket.Surgery.LaunchPad.Foundation - 43.3%
Rocket.Surgery.LaunchPad.Foundation.NewtonsoftJson - 64.4%
Rocket.Surgery.LaunchPad.Grpc - 41.1%
Rocket.Surgery.LaunchPad.Hosting - 48%
Rocket.Surgery.LaunchPad.Mapping - 38.3%
Rocket.Surgery.LaunchPad.Metadata - 49.7%
Rocket.Surgery.LaunchPad.Primitives - 71.6%
Rocket.Surgery.LaunchPad.Serilog - 60%
Rocket.Surgery.LaunchPad.Spatial - 59.3%
Rocket.Surgery.LaunchPad.Spatial.NewtonsoftJson - 37.2%
Rocket.Surgery.LaunchPad.StrawberryShake - 47.8%
Rocket.Surgery.LaunchPad.StrawberryShake.Spatial - 8.8%
Rocket.Surgery.LaunchPad.Telemetry - 20.8%
Rocket.Surgery.LaunchPad.Testing - 13.2%
Sample.BlazorServer - 5.2%
Sample.BlazorServer.Tests - 29%
Sample.BlazorWasm.Tests - 15.7%
Sample.Classic.Restful - 3.5%
Sample.Classic.Restful.Tests - 41%
Sample.Command.Tests - 16.3%
Sample.Core - 75.8%
Sample.Core.Tests - 55.3%
Sample.Graphql.Tests - 58.9%
Sample.Grpc - 73.2%
Sample.Grpc.Tests - 41.7%
Sample.Minimal - 16.2%
Sample.Minimal.Tests - 28%
Sample.Pages - 5.6%
Sample.Pages.Tests - 29.6%
Sample.Restful - 4%
Sample.Restful.Tests - 40%
Sample.Worker.Tests - 16.3%
|
There was a problem hiding this comment.
Pull Request Overview
This PR has a critical scope misalignment that prevents approval. The title and description specify an update for Microsoft.CodeAnalysis (Roslyn) packages to version 5.3.0, but the implementation updates the 'FairyBread' package to version 12.0.0 instead. None of the required Roslyn package updates are present in the provided changes. This suggests the PR may have been incorrectly generated or contains unintended manual modifications.
About this PR
- Complete scope misalignment: The PR description and title specify Roslyn package updates, but the code changes only reflect an update to a different package entirely.
Test suggestions
- Verify Roslyn packages are updated to version 5.3.0 in Directory.Packages.props
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify Roslyn packages are updated to version 5.3.0 in Directory.Packages.props
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
|
|
||
| <PackageVersion Include="FairyBread"> | ||
| <Version>11.0.0</Version> | ||
| <Version>12.0.0</Version> |
There was a problem hiding this comment.
🔴 HIGH RISK
The implementation updates 'FairyBread', which is not mentioned in the PR description or title. Furthermore, the requested updates for Microsoft.CodeAnalysis packages are entirely missing from the diff.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
This PR contains the following updates:
5.0.0→5.3.05.0.0→5.3.05.0.0→5.3.05.0.0→5.3.05.0.0→5.3.0Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.