Update polly monorepo#2997
Conversation
Test Results760 tests ±0 756 ✅ ±0 4m 15s ⏱️ -3s Results for commit 9f5f056. ± Comparison against base commit 89d7c0c. This pull request removes 7 and adds 7 tests. Note that renamed tests count towards both. |
SummarySummary
CoverageAnalyzers.Tests - 96.9%
AspNetCore.FluentValidation.OpenApi.Tests - 46%
AspNetCore.Tests - 23.8%
Extensions.Tests - 88.8%
Metadata.Tests - 28.6%
Rocket.Surgery.LaunchPad.Analyzers - 90.1%
Rocket.Surgery.LaunchPad.AspNetCore - 49.7%
Rocket.Surgery.LaunchPad.AspNetCore.FluentValidation.OpenApi - 62.3%
Rocket.Surgery.LaunchPad.AspNetCore.Testing - 47.2%
Rocket.Surgery.LaunchPad.EntityFramework - 29.3%
Rocket.Surgery.LaunchPad.Foundation - 43.3%
Rocket.Surgery.LaunchPad.Foundation.NewtonsoftJson - 64.4%
Rocket.Surgery.LaunchPad.Grpc - 41.1%
Rocket.Surgery.LaunchPad.Hosting - 48%
Rocket.Surgery.LaunchPad.Mapping - 38.3%
Rocket.Surgery.LaunchPad.Metadata - 49.7%
Rocket.Surgery.LaunchPad.Primitives - 71.6%
Rocket.Surgery.LaunchPad.Serilog - 60%
Rocket.Surgery.LaunchPad.Spatial - 59.3%
Rocket.Surgery.LaunchPad.Spatial.NewtonsoftJson - 37.2%
Rocket.Surgery.LaunchPad.StrawberryShake - 47.8%
Rocket.Surgery.LaunchPad.StrawberryShake.Spatial - 8.8%
Rocket.Surgery.LaunchPad.Telemetry - 20.8%
Rocket.Surgery.LaunchPad.Testing - 13.2%
Sample.BlazorServer - 5.2%
Sample.BlazorServer.Tests - 29%
Sample.BlazorWasm.Tests - 15.7%
Sample.Classic.Restful - 3.5%
Sample.Classic.Restful.Tests - 41%
Sample.Command.Tests - 16.3%
Sample.Core - 75.8%
Sample.Core.Tests - 55.3%
Sample.Graphql.Tests - 58.9%
Sample.Grpc - 73.2%
Sample.Grpc.Tests - 41.7%
Sample.Minimal - 16.2%
Sample.Minimal.Tests - 28%
Sample.Pages - 5.6%
Sample.Pages.Tests - 29.6%
Sample.Restful - 4%
Sample.Restful.Tests - 40%
Sample.Worker.Tests - 16.3%
|
There was a problem hiding this comment.
Pull Request Overview
The PR implementation fails to meet the core requirement. Although the title and description indicate an update to the Polly library, the actual code change updates FairyBread instead. This represents a significant gap in acceptance criteria as the requested Polly update is entirely missing. Furthermore, the modification to FairyBread uses a nested XML element for versioning, which deviates from the attribute-based style established in the rest of the file. The PR should be revised to align the implementation with the intended package update and adhere to existing code style conventions.
About this PR
- Significant misalignment detected between the PR description and the implementation: the PR claims to update 'Polly' but the code updates 'FairyBread' instead. The requested update for the Polly package is completely missing from the provided diff.
Test suggestions
- Verify Polly package version is updated
- Verify FairyBread package version is updated
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify Polly package version is updated
2. Verify FairyBread package version is updated
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
|
|
||
| <PackageVersion Include="FairyBread"> | ||
| <Version>11.0.0</Version> | ||
| <Version>12.0.0</Version> |
There was a problem hiding this comment.
🔴 HIGH RISK
This line updates the FairyBread package, which contradicts the PR title and description specifying an update for the Polly library. Furthermore, the definition for 'FairyBread' is inconsistent with the rest of the file; use the 'Version' attribute instead of a nested element to match the established style.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
This PR contains the following updates:
8.5.2→8.7.0Release Notes
App-vNext/Polly (Polly)
v8.7.0Compare Source
v8.6.6Compare Source
ScheduledTaskExecutordeadlock whenTrySetResultruns continuations inline by @crnhrv in #2953v8.6.5Compare Source
TimeoutRejectedExceptionby @martincostello in #2827v8.6.4Compare Source
v8.6.3Compare Source
v8.6.2Compare Source
v8.6.1Compare Source
BulkheadSemaphoreFactoryby @ahusseini in #2638v8.6.0Compare Source
AttemptNumbertoHedgingPredicateArgumentsby @peter-csala in #2603OnRetryArgumentscomments by @lchaoer in #2627Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.