Update open-telemetry#2996
Conversation
Test Results760 tests ±0 756 ✅ ±0 4m 13s ⏱️ -5s Results for commit 2df81ef. ± Comparison against base commit 89d7c0c. This pull request removes 7 and adds 7 tests. Note that renamed tests count towards both. |
SummarySummary
CoverageAnalyzers.Tests - 96.9%
AspNetCore.FluentValidation.OpenApi.Tests - 46%
AspNetCore.Tests - 23.8%
Extensions.Tests - 88.8%
Metadata.Tests - 28.6%
Rocket.Surgery.LaunchPad.Analyzers - 90.1%
Rocket.Surgery.LaunchPad.AspNetCore - 49.7%
Rocket.Surgery.LaunchPad.AspNetCore.FluentValidation.OpenApi - 62.3%
Rocket.Surgery.LaunchPad.AspNetCore.Testing - 47.2%
Rocket.Surgery.LaunchPad.EntityFramework - 29.3%
Rocket.Surgery.LaunchPad.Foundation - 43.3%
Rocket.Surgery.LaunchPad.Foundation.NewtonsoftJson - 64.4%
Rocket.Surgery.LaunchPad.Grpc - 41.1%
Rocket.Surgery.LaunchPad.Hosting - 48%
Rocket.Surgery.LaunchPad.Mapping - 38.3%
Rocket.Surgery.LaunchPad.Metadata - 49.7%
Rocket.Surgery.LaunchPad.Primitives - 71.6%
Rocket.Surgery.LaunchPad.Serilog - 60%
Rocket.Surgery.LaunchPad.Spatial - 59.3%
Rocket.Surgery.LaunchPad.Spatial.NewtonsoftJson - 37.2%
Rocket.Surgery.LaunchPad.StrawberryShake - 47.8%
Rocket.Surgery.LaunchPad.StrawberryShake.Spatial - 8.8%
Rocket.Surgery.LaunchPad.Telemetry - 20.8%
Rocket.Surgery.LaunchPad.Testing - 13.2%
Sample.BlazorServer - 5.2%
Sample.BlazorServer.Tests - 29%
Sample.BlazorWasm.Tests - 15.7%
Sample.Classic.Restful - 3.5%
Sample.Classic.Restful.Tests - 41%
Sample.Command.Tests - 16.3%
Sample.Core - 75.8%
Sample.Core.Tests - 55.3%
Sample.Graphql.Tests - 58.9%
Sample.Grpc - 73.2%
Sample.Grpc.Tests - 41.7%
Sample.Minimal - 16.2%
Sample.Minimal.Tests - 28%
Sample.Pages - 5.6%
Sample.Pages.Tests - 29.6%
Sample.Restful - 4%
Sample.Restful.Tests - 40%
Sample.Worker.Tests - 16.3%
|
There was a problem hiding this comment.
Pull Request Overview
The PR implementation is fundamentally misaligned with its stated intent. While the title and description specify updates to several OpenTelemetry components, the code changes modify an unrelated package not mentioned in the requirements. Furthermore, the implementation introduces a syntax inconsistency in the configuration file, and all specified acceptance criteria remain unaddressed. Because the core requirements are missing, the PR is not ready for merging.
About this PR
- The PR implementation is completely misaligned with the provided title and description. The expected package updates are missing from the code diff, and an unrelated package update was included instead.
Test suggestions
- Verify core and hosting packages are updated
- Verify instrumentation packages are updated
- Verify the additional package update matches intended specifications
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify core and hosting packages are updated
2. Verify instrumentation packages are updated
3. Verify the additional package update matches intended specifications
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
|
|
||
| <PackageVersion Include="FairyBread"> | ||
| <Version>11.0.0</Version> | ||
| <Version>12.0.0</Version> |
There was a problem hiding this comment.
🔴 HIGH RISK
The package updated in this file does not match the PR title and description, and the intended updates are missing. Additionally, the XML structure used for this entry is inconsistent with the attribute-based versioning convention applied to other packages in this file.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
This PR contains the following updates:
1.12.0→1.16.01.12.0→1.16.01.12.0→1.15.21.12.0→1.15.11.12.0→1.15.1Release Notes
open-telemetry/opentelemetry-dotnet (OpenTelemetry)
v1.16.0Release details: 1.16.0
10 million values.
BaggagePropagatorto correctly follow Key and Value Encoding rules.TraceContextPropagatorto deduplicate duplicatetracestatekeys.ObservedTimestampwill now be exported for logs in the console exporter.NullReferenceExceptionwhen exporting OTLP logs if the scope key isnull.
storage retry.
OtlpLogExporterintegration withIHttpClientFactory.IHttpClientFactorywhen mTLS isenabled.
Retry-Afterresponse headers that specify a date instead of a delay.observed_time_unix_nanowill no longer always be identical totime_unix_nanowhen using the logs bridge API.
Nameagainst the instrument namesyntax.
OTEL_BSP_*andOTEL_BLRP_*environment variables.collection cycle.
ExemplarReservoirimplementations.LoggerProviderto fail toresolve when one of its dependencies depends on
ILoggerorILoggerFactory.v1.15.3Release details: 1.15.3
tracestateparsing to reject keys that do notbegin with a lowercase letter, including keys beginning with digits, to
align with the W3C Trace Context specification.
Disk retry now requires
OTEL_DOTNET_EXPERIMENTAL_OTLP_DISK_RETRY_DIRECTORY_PATHwhen
OTEL_DOTNET_EXPERIMENTAL_OTLP_RETRY=diskis configured.OtlpLogExporternow usesIHttpClientFactoryon .NET 8+.OTEL_SPAN_ATTRIBUTE_VALUE_LENGTH_LIMITnot being applied.BaggagePropagatorto trim optional whitespace (OWS) around=separators when parsing the
baggageheader.BaggagePropagatorto strip baggage properties from values whenparsing the
baggageheader.LogRecord.LogLevelto preserveLogLevel.None.OTEL_TRACES_SAMPLER_ARGhandling for out-of-range values.traces storage directory.
serialization.
v1.15.2Release details: 1.15.2
export fails and error logging is enabled.
BatchExportProcessorandPeriodicExportingMetricReaderto enable the OpenTelemetry SDK to workin single-threaded WebAssembly environments such as Blazor and
Uno Platform.
v1.15.1Release details: 1.15.1
treats baggage names and values as case sensitive, aligning with the latest
Baggage API specification.
OpenTelemetry.ApiandOpenTelemetrySDK,including fixes for thread-safety, sampler edge cases, metrics precision,
and observable instrument lifecycle handling.
v1.15.0Release details: 1.15.0
ActivitySource.TelemetrySchemaUrland
Meter.TelemetrySchemaUrlproperties across exporters.CA certificate options).
OpenTelemetry.Exporter.Zipkinis deprecated and will stop receiving updatesin December 2026. Zipkin already supports OTLP ingestion.
Migrate to
OpenTelemetry.Exporter.OpenTelemetryProtocolas statedin the Deprecating Zipkin Exporter blog post.
v1.14.0Release details: 1.14.0
net8.0, the package now depends on version8.0.0of theMicrosoft.Extensions.DependencyInjection.Abstractions,Microsoft.Extensions.Diagnostics.Abstractions,Microsoft.Extensions.Hosting.AbstractionsandMicrosoft.Extensions.Logging.ConfigurationNuGet packages.System.Diagnostics.DiagnosticSourcedependency to10.0.0for all target frameworks.
Microsoft.Extensions.*dependencies to10.0.0for .NET Framework and .NET Standard.
(
.sigstore.json) for digital signatures instead of separate signature(
.sig) and certificate (.pem) files. This requires cosign 3.0 or laterfor verification. See the Digital signing
section for updated verification instructions.
v1.13.1Release details: 1.13.1
1.13.0, the digital signature (.dll-keyless.sig) andcertificate (
.dll-keyless.pem) files were unintentionally omitted from thepublished NuGet packages.
(
net462,netstandard2.0,netstandard2.1,net8.0,net9.0), ensuringthe integrity of DLL verification using Sigstore cosign.
v1.13.0Release details: 1.13.0
OtlpExportProtocol.Grpcnow set the
TE=trailersHTTP request header to improve interoperability.EventNameis now exported by default asEventNameinstead oflogrecord.event.namewhen specified throughILoggeror the experimentallog bridge API.
open-telemetry/opentelemetry-dotnet-contrib (OpenTelemetry.Instrumentation.AspNetCore)
v1.15.1Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.