You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
[!IMPORTANT] Upgrade directly from v14.6.3 to v14.7.1 — skip v14.7.0.
v14.7.0 bundled NJsonSchema v11.6.0, which contained a regression that silently dropped nullability on required T? / [JsonRequired] T? DTO properties. The resulting OpenAPI/JSON schema marked those properties as non-nullable, so generated TypeScript and C# clients lost null-safety for fields the server can legitimately return as null (#5359).
Corrections to v14.7.0
v14.7.1 updates to NJsonSchema v11.6.1, which corrects the handling of the C# required keyword and [JsonRequired]:
These are now treated as presence markers (the property must be present in the JSON) rather than value constraints.
Nullability from the declared type (string?, T?) is preserved.
No spurious MinLength=1 on non-nullable strings.
DataAnnotations [Required] semantics remain unchanged (still suppresses nullability and adds MinLength=1 to strings by default, matching its runtime behavior).
Observable client changes vs v14.7.0
For public required string[]? OptionList { get; init; } (#5359):
C# 11 required keyword now correctly recognized: Properties using the C# 11 required keyword (via RequiredMemberAttribute / JsonRequiredAttribute) are now properly treated as required in the schema and generated code. Previously these were incorrectly treated as optional.
Removed extra blank line before class declarations in generated C# controller code (cosmetic).
New WriteAccessor setting to control property setter syntax (set vs init).
New JsonLibraryVersion setting for controlling enum attribute generation with System.Text.Json.
Fixed MinLength validation no longer incorrectly applied to DateTime properties.
Fixed nullable enum array detection for string enum converters.
Support for public fields with System.Text.Json when IncludeFields is enabled.
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
The implementation in this pull request does not align with its stated requirements. The title and description specify an update for a particular set of packages, but the code diff modifies a completely different, unrelated dependency. Consequently, the primary acceptance criterion—updating the intended package—remains unaddressed. This mismatch indicates that the intended changes are missing from the submission and should be corrected before the pull request is merged.
About this PR
There is a total mismatch between the pull request title/description and the actual code changes. The submission claims to update one dependency but modifies a different one, leaving the intended update entirely missing from the diff.
Test suggestions
Verify NSwag.ApiDescription.Client is updated to 14.7.1
Verify FairyBread is updated to 12.0.0
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify NSwag.ApiDescription.Client is updated to 14.7.1
The reason will be displayed to describe this comment to others. Learn more.
🔴 HIGH RISK
This change modifies a dependency that does not match the package specified in the pull request title and description. The intended update is missing from the file changes.
Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.
⚠️Warning: custom changes will be lost.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📦 dependenciesPull requests that update a dependency file
0 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
renovate
Bot
added
the
📦 dependencies
![codacy-production[bot]](https://avatars.githubusercontent.com/in/56611?s=60&v=4){kind=small}
This PR contains the following updates:
14.5.0→14.7.1Release Notes
RicoSuter/NSwag (NSwag.ApiDescription.Client)
v14.7.1: NSwag v14.7.1 (NJsonSchema v11.6.1)Corrections to v14.7.0
v14.7.1 updates to NJsonSchema v11.6.1, which corrects the handling of the C#
requiredkeyword and[JsonRequired]:string?,T?) is preserved.MinLength=1on non-nullable strings.[Required]semantics remain unchanged (still suppresses nullability and addsMinLength=1to strings by default, matching its runtime behavior).Observable client changes vs v14.7.0
For
public required string[]? OptionList { get; init; }(#5359):optionList: string[]❌public string[] OptionList❌optionList: string[] | null✅public string[]? OptionList✅For full details and truth tables across all
required/[Required]/[JsonRequired]/[JsonProperty(Required=*)]combinations, see the NJsonSchema v11.6.1 release notes and NJsonSchema #1919.What's Changed
Full Changelog: RicoSuter/NSwag@v14.7.0...v14.7.1
v14.7.0: NSwag v14.7.0 (NJsonSchema v11.6.0)What's Changed
NSwag.Npmresulting in aNConsole.UnusedArgumentExceptionby @ptasev in #5320NJsonSchema v11.6.0 (potentially breaking changes)
This release updates to NJsonSchema v11.6.0 and Namotion.Reflection v3.5.0, which include the following changes that may affect generated code:
requiredkeyword now correctly recognized: Properties using the C# 11requiredkeyword (viaRequiredMemberAttribute/JsonRequiredAttribute) are now properly treated as required in the schema and generated code. Previously these were incorrectly treated as optional.WriteAccessorsetting to control property setter syntax (setvsinit).JsonLibraryVersionsetting for controlling enum attribute generation with System.Text.Json.MinLengthvalidation no longer incorrectly applied to DateTime properties.IncludeFieldsis enabled.For the full list of changes, see the NJsonSchema v11.6.0 release notes.
New Contributors
Full Changelog: RicoSuter/NSwag@v14.6.3...v14.7.0
v14.6.3: NSwag v14.6.3 (NJsonSchema v11.5.2)What's Changed
New Contributors
Full Changelog: RicoSuter/NSwag@v14.6.2...v14.6.3
v14.6.2: NSwag v14.6.2 (NJsonSchema v11.5.2)Fixes EnumValue regression in v14.6.1 by introducing a new JsonLibraryVersion configuration (default 8.0)
What's Changed
Full Changelog: RicoSuter/NSwag@v14.6.1...v14.6.2
v14.6.1: NSwag v14.6.1 (NJsonSchema v11.5.1)What's Changed
New Contributors
Full Changelog: RicoSuter/NSwag@v14.6.0...v14.6.1
v14.6.0: NSwag v14.6.0 (NJsonSchema v11.5.0)What's Changed
New Contributors
Full Changelog: RicoSuter/NSwag@v14.5.0...v14.6.0
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.