You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Removal of the net6.0 target framework, as .NET 6.0 has been EOL for over a year
Added Period.NanosecondsBetween method
Documentation fixes
Added a new namespace, NodaTime.HighPerformance, containing Duration64 and Instant64 types (for high-performance scenarios where the larger size (in memory) of Duration and Instant is problematic
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
While the automated quality analysis indicates the code is technically 'up to standards', the pull request fails to meet any of its acceptance criteria. The implementation modifies the 'FairyBread' package, whereas the title and description explicitly request updates for NodaTime and its associated serialization libraries. This significant discrepancy between intent and implementation must be resolved before merging.
About this PR
The PR title and description specify updates for NodaTime dependencies, but the implementation modifies the 'FairyBread' package instead. All required NodaTime updates are entirely missing from this change.
Test suggestions
Verify NodaTime version is updated in Directory.Packages.props
Verify NodaTime.Serialization.JsonNet version is updated in Directory.Packages.props
Verify NodaTime.Serialization.SystemTextJson version is updated in Directory.Packages.props
Verify NodaTime.Testing version is updated in Directory.Packages.props
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify NodaTime version is updated in Directory.Packages.props
2. Verify NodaTime.Serialization.JsonNet version is updated in Directory.Packages.props
3. Verify NodaTime.Serialization.SystemTextJson version is updated in Directory.Packages.props
4. Verify NodaTime.Testing version is updated in Directory.Packages.props
The reason will be displayed to describe this comment to others. Learn more.
🔴 HIGH RISK
This implementation contradicts the PR description and title. The code updates the 'FairyBread' package instead of the NodaTime packages specified in the requirements. Please ensure the intended dependencies are updated or align the PR metadata with these changes.
Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.
⚠️Warning: custom changes will be lost.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📦 dependenciesPull requests that update a dependency file
0 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
renovate
Bot
added
the
📦 dependencies
![codacy-production[bot]](https://avatars.githubusercontent.com/in/56611?s=60&v=4){kind=small}
This PR contains the following updates:
3.2.2→3.3.23.2.0→3.3.01.3.0→1.4.03.2.2→3.3.2Release Notes
nodatime/nodatime (NodaTime)
v3.3.2Compare Source
v3.3.1Compare Source
v3.3.0: Release Noda Time 3.3.0Compare Source
Changes since 3.2.0:
v3.2.5Compare Source
v3.2.4Compare Source
v3.2.3Compare Source
nodatime/nodatime.serialization (NodaTime.Serialization.JsonNet)
v3.3.0: NodaTime.Serialization.JsonNet version 3.3.0Compare Source
Changes since 3.2.1:
v3.2.1: NodaTime.Serialization.JsonNet version 3.2.1Compare Source
Changes since 3.2.0:
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.