Update dependency Riok.Mapperly to 4.3.1#2989
Conversation
Test Results 16 files ±0 16 suites ±0 3m 57s ⏱️ -21s Results for commit d3841c6. ± Comparison against base commit 89d7c0c. This pull request removes 7 and adds 5 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
SummarySummary
CoverageAnalyzers.Tests - 96.9%
AspNetCore.FluentValidation.OpenApi.Tests - 46%
AspNetCore.Tests - 23.8%
Extensions.Tests - 88.8%
Metadata.Tests - 28.6%
Rocket.Surgery.LaunchPad.Analyzers - 90.1%
Rocket.Surgery.LaunchPad.AspNetCore - 49.7%
Rocket.Surgery.LaunchPad.AspNetCore.FluentValidation.OpenApi - 62.3%
Rocket.Surgery.LaunchPad.AspNetCore.Testing - 47.2%
Rocket.Surgery.LaunchPad.EntityFramework - 29.3%
Rocket.Surgery.LaunchPad.Foundation - 43.3%
Rocket.Surgery.LaunchPad.Foundation.NewtonsoftJson - 64.4%
Rocket.Surgery.LaunchPad.Grpc - 41.1%
Rocket.Surgery.LaunchPad.Hosting - 48%
Rocket.Surgery.LaunchPad.Mapping - 38.3%
Rocket.Surgery.LaunchPad.Metadata - 49.7%
Rocket.Surgery.LaunchPad.Primitives - 71.6%
Rocket.Surgery.LaunchPad.Serilog - 60%
Rocket.Surgery.LaunchPad.Spatial - 59.3%
Rocket.Surgery.LaunchPad.Spatial.NewtonsoftJson - 37.2%
Rocket.Surgery.LaunchPad.StrawberryShake - 47.8%
Rocket.Surgery.LaunchPad.StrawberryShake.Spatial - 8.8%
Rocket.Surgery.LaunchPad.Telemetry - 20.8%
Rocket.Surgery.LaunchPad.Testing - 13.2%
Sample.BlazorServer - 5.2%
Sample.BlazorServer.Tests - 29%
Sample.BlazorWasm.Tests - 15.7%
Sample.Classic.Restful - 3.5%
Sample.Classic.Restful.Tests - 41%
Sample.Command.Tests - 16.3%
Sample.Core - 75.8%
Sample.Core.Tests - 55.3%
Sample.Graphql.Tests - 58.9%
Sample.Grpc - 73.2%
Sample.Grpc.Tests - 41.7%
Sample.Minimal - 16.2%
Sample.Minimal.Tests - 28%
Sample.Pages - 5.6%
Sample.Pages.Tests - 29.6%
Sample.Restful - 4%
Sample.Restful.Tests - 40%
Sample.Worker.Tests - 16.3%
|
1cccd35 to
d3841c6
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR is currently not fit for merging due to a critical discrepancy between the intent and the implementation. While the metadata indicates the project is up to standards and the title describes a version bump for 'Riok.Mapperly' to 4.3.1, the code only updates 'FairyBread' to 12.0.0. The primary acceptance criterion (updating Mapperly) has not been met.
Additionally, the change to 'FairyBread' introduces a minor stylistic inconsistency with the rest of the project's dependency management file. You should clarify whether the intended update was for Riok.Mapperly or FairyBread and ensure the code and PR title are aligned.
About this PR
- The PR title and description focus on 'Riok.Mapperly', but the code diff is restricted to 'FairyBread'. The requested update for 'Riok.Mapperly' is entirely missing.
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
|
|
||
| <PackageVersion Include="FairyBread"> | ||
| <Version>11.0.0</Version> | ||
| <Version>12.0.0</Version> |
There was a problem hiding this comment.
🔴 HIGH RISK
This line updates 'FairyBread' to 12.0.0, which contradicts the PR's stated purpose of updating 'Riok.Mapperly' to 4.3.1. Please verify the correct dependency target. Additionally, for consistency with other entries in this file (e.g., line 27), use the 'Version' attribute instead of a nested element.
Try running the following prompt in your IDE agent:
Replace the multi-line PackageVersion for 'FairyBread' with a single-line version using the Version attribute:
<PackageVersion Include="FairyBread" Version="12.0.0" />
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
This PR contains the following updates:
4.2.1→4.3.1Release Notes
riok/mapperly (Riok.Mapperly)
v4.3.1🐛 Bug Fixes
Full Changelog: riok/mapperly@v4.3.0...v4.3.1
v4.3.0🚀 Features
🐛 Bug Fixes
Full Changelog: riok/mapperly@v4.2.1...v4.3.0
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.