Update serilog#2986
Open
renovate[bot] wants to merge 1 commit into
Open
Conversation
renovate
Bot
added
the
📦 dependencies
Test Results760 tests ±0 756 ✅ ±0 3m 59s ⏱️ -14s Results for commit 65e46a9. ± Comparison against base commit f0fbecb. This pull request removes 7 and adds 7 tests. Note that renamed tests count towards both. |
SummarySummary
CoverageAnalyzers.Tests - 96.9%
AspNetCore.FluentValidation.OpenApi.Tests - 46%
AspNetCore.Tests - 23.8%
Extensions.Tests - 88.8%
Metadata.Tests - 28.6%
Rocket.Surgery.LaunchPad.Analyzers - 90.1%
Rocket.Surgery.LaunchPad.AspNetCore - 49.7%
Rocket.Surgery.LaunchPad.AspNetCore.FluentValidation.OpenApi - 62.3%
Rocket.Surgery.LaunchPad.AspNetCore.Testing - 47.2%
Rocket.Surgery.LaunchPad.EntityFramework - 29.3%
Rocket.Surgery.LaunchPad.Foundation - 43.3%
Rocket.Surgery.LaunchPad.Foundation.NewtonsoftJson - 64.4%
Rocket.Surgery.LaunchPad.Grpc - 41.1%
Rocket.Surgery.LaunchPad.Hosting - 48%
Rocket.Surgery.LaunchPad.Mapping - 38.3%
Rocket.Surgery.LaunchPad.Metadata - 49.7%
Rocket.Surgery.LaunchPad.Primitives - 71.6%
Rocket.Surgery.LaunchPad.Serilog - 60%
Rocket.Surgery.LaunchPad.Spatial - 59.3%
Rocket.Surgery.LaunchPad.Spatial.NewtonsoftJson - 37.2%
Rocket.Surgery.LaunchPad.StrawberryShake - 47.8%
Rocket.Surgery.LaunchPad.StrawberryShake.Spatial - 8.8%
Rocket.Surgery.LaunchPad.Telemetry - 20.8%
Rocket.Surgery.LaunchPad.Testing - 13.2%
Sample.BlazorServer - 5.2%
Sample.BlazorServer.Tests - 29%
Sample.BlazorWasm.Tests - 15.7%
Sample.Classic.Restful - 3.5%
Sample.Classic.Restful.Tests - 41%
Sample.Command.Tests - 16.3%
Sample.Core - 75.8%
Sample.Core.Tests - 55.3%
Sample.Graphql.Tests - 58.9%
Sample.Grpc - 73.2%
Sample.Grpc.Tests - 41.7%
Sample.Minimal - 16.2%
Sample.Minimal.Tests - 28%
Sample.Pages - 5.6%
Sample.Pages.Tests - 29.6%
Sample.Restful - 4%
Sample.Restful.Tests - 40%
Sample.Worker.Tests - 16.3%
|
![codacy-production[bot]](https://avatars.githubusercontent.com/in/56611?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull Request Overview
Although the automated analysis indicates the PR is up to standards, there is a fundamental mismatch between the PR title/description and the implementation. The PR claims to update Serilog.Sinks.ApplicationInsights and Serilog.Sinks.Console, but the actual diff only updates the 'Alba' package. Consequently, the acceptance criteria for the Serilog updates are entirely unaddressed. This PR should not be merged until the code changes align with the stated requirements or the description is corrected to reflect the actual changes.
About this PR
- There is a complete mismatch between the PR title/description and the code changes. The PR claims to update Serilog packages, but the diff only shows an update for the 'Alba' package.
Test suggestions
- Verify Serilog.Sinks.ApplicationInsights is updated to 4.1.0 in Directory.Packages.props
- Verify Serilog.Sinks.Console is updated to 6.1.1 in Directory.Packages.props
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify Serilog.Sinks.ApplicationInsights is updated to 4.1.0 in Directory.Packages.props
2. Verify Serilog.Sinks.Console is updated to 6.1.1 in Directory.Packages.props
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
| <PackageVersion Include="OpenTelemetry.Instrumentation.Runtime" Version="1.12.0" /> | ||
| <PackageVersion Include="OpenTelemetry.Instrumentation.AspNetCore" Version="1.12.0" /> | ||
| <PackageVersion Include="Alba" Version="8.2.1" /> | ||
| <PackageVersion Include="Alba" Version="8.5.2" /> |
There was a problem hiding this comment.
🔴 HIGH RISK
This change updates 'Alba' to version 8.5.2, but the PR description and title specify updates for Serilog.Sinks.ApplicationInsights and Serilog.Sinks.Console. The expected Serilog updates are missing from this file. If the intention was to update Alba, please update the PR title and description to reflect this change correctly.
Up to standards ✅🟢 Issues
|
Contributor
Author
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
4.1.0-dev-02304→4.1.06.0.0→6.1.1Release Notes
serilog-contrib/serilog-sinks-applicationinsights (Serilog.Sinks.ApplicationInsights)
v4.1.0READMEspelling corrections (@Davidmendoza1987)TelemetryClient.DisposeAsync()(@agehrke)TraceIdandSpanIdsupport @hangy)serilog/serilog-sinks-console (Serilog.Sinks.Console)
v6.1.1What's Changed
Full Changelog: serilog/serilog-sinks-console@v6.1.0...v6.1.1
v6.1.0{UtcTimestamp}in output templates (@ManuelRin)Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.