Update dependency verify.tool to v0.7.0#2843
Open
renovate[bot] wants to merge 1 commit into
Open
Conversation
renovate
Bot
added
the
📦 dependencies
Test Results 16 files ±0 16 suites ±0 3m 57s ⏱️ -15s Results for commit a579499. ± Comparison against base commit d6a7a38. This pull request removes 6 and adds 7 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
SummarySummary
CoverageAnalyzers.Tests - 96.9%
AspNetCore.FluentValidation.OpenApi.Tests - 46%
AspNetCore.Tests - 23.8%
Extensions.Tests - 88.8%
Metadata.Tests - 28.6%
Rocket.Surgery.LaunchPad.Analyzers - 90.1%
Rocket.Surgery.LaunchPad.AspNetCore - 49.7%
Rocket.Surgery.LaunchPad.AspNetCore.FluentValidation.OpenApi - 62.3%
Rocket.Surgery.LaunchPad.AspNetCore.Testing - 47.2%
Rocket.Surgery.LaunchPad.EntityFramework - 29.3%
Rocket.Surgery.LaunchPad.Foundation - 43.3%
Rocket.Surgery.LaunchPad.Foundation.NewtonsoftJson - 64.4%
Rocket.Surgery.LaunchPad.Grpc - 41.1%
Rocket.Surgery.LaunchPad.Hosting - 48%
Rocket.Surgery.LaunchPad.Mapping - 38.3%
Rocket.Surgery.LaunchPad.Metadata - 49.7%
Rocket.Surgery.LaunchPad.Primitives - 71.6%
Rocket.Surgery.LaunchPad.Serilog - 60%
Rocket.Surgery.LaunchPad.Spatial - 59.3%
Rocket.Surgery.LaunchPad.Spatial.NewtonsoftJson - 37.2%
Rocket.Surgery.LaunchPad.StrawberryShake - 47.8%
Rocket.Surgery.LaunchPad.StrawberryShake.Spatial - 8.8%
Rocket.Surgery.LaunchPad.Telemetry - 20.8%
Rocket.Surgery.LaunchPad.Testing - 13.2%
Sample.BlazorServer - 5.2%
Sample.BlazorServer.Tests - 29%
Sample.BlazorWasm.Tests - 15.7%
Sample.Classic.Restful - 3.5%
Sample.Classic.Restful.Tests - 41%
Sample.Command.Tests - 16.3%
Sample.Core - 75.8%
Sample.Core.Tests - 55.3%
Sample.Graphql.Tests - 58.9%
Sample.Grpc - 73.2%
Sample.Grpc.Tests - 41.7%
Sample.Minimal - 16.2%
Sample.Minimal.Tests - 28%
Sample.Pages - 5.6%
Sample.Pages.Tests - 29.6%
Sample.Restful - 4%
Sample.Restful.Tests - 40%
Sample.Worker.Tests - 16.3%
|
renovate
Bot
force-pushed
the
renovate/verify.tool-0.x
branch
from
2a87188 to
6f6f755
Compare
renovate
Bot
force-pushed
the
renovate/verify.tool-0.x
branch
from
6f6f755 to
1bde13d
Compare
renovate
Bot
force-pushed
the
renovate/verify.tool-0.x
branch
2 times, most recently
from
29480a4 to
4fcbe8c
Compare
renovate
Bot
force-pushed
the
renovate/verify.tool-0.x
branch
from
4fcbe8c to
0dab32e
Compare
renovate
Bot
force-pushed
the
renovate/verify.tool-0.x
branch
from
0dab32e to
1194d8a
Compare
renovate
Bot
force-pushed
the
renovate/verify.tool-0.x
branch
from
1194d8a to
25af76d
Compare
renovate
Bot
force-pushed
the
renovate/verify.tool-0.x
branch
from
25af76d to
4221f72
Compare
renovate
Bot
force-pushed
the
renovate/verify.tool-0.x
branch
from
4221f72 to
a579499
Compare
![codacy-production[bot]](https://avatars.githubusercontent.com/in/56611?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull Request Overview
This PR contains a major scope misalignment that prevents merging in its current state. While the PR title and description indicate an update to the verify.tool dependency, the actual code changes modify the husky package.
Although the changes are technically 'up to standards' according to Codacy, the discrepancy between the stated objective and the implementation suggests either incorrect metadata or an error in the dependency being targeted. This must be resolved to maintain an accurate project history.
About this PR
- Major scope misalignment: The PR description and title claim to update 'verify.tool', but the code diff shows an update to 'husky'. The intended update for 'verify.tool' is entirely missing from the provided code changes.
Test suggestions
- Verify verify.tool version is updated in dotnet-tools.json
- Verify husky functionality after update
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify verify.tool version is updated in dotnet-tools.json
2. Verify husky functionality after update
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
| }, | ||
| "husky": { | ||
| "version": "0.7.2", | ||
| "version": "0.9.1", |
There was a problem hiding this comment.
🟡 MEDIUM RISK
The PR title and description specify an update for verify.tool, but the code modifies the husky package instead. This discrepancy between the stated intent and the implementation should be corrected. If husky was the intended target, the PR metadata should be updated; otherwise, the correct package should be modified.
Up to standards ✅🟢 Issues
|
Contributor
Author
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
0.6.0→0.7.0Release Notes
patriksvensson/verify.terminal (verify.tool)
v0.7.0Compare Source
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.