Update dependency dotnet-coverage to v18#2771
Conversation
Test Results760 tests ±0 756 ✅ ±0 4m 6s ⏱️ -7s Results for commit 7bb2d6d. ± Comparison against base commit f0fbecb. This pull request removes 7 and adds 7 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
SummarySummary
CoverageAnalyzers.Tests - 96.9%
AspNetCore.FluentValidation.OpenApi.Tests - 46%
AspNetCore.Tests - 23.8%
Extensions.Tests - 88.8%
Metadata.Tests - 28.6%
Rocket.Surgery.LaunchPad.Analyzers - 90.1%
Rocket.Surgery.LaunchPad.AspNetCore - 49.7%
Rocket.Surgery.LaunchPad.AspNetCore.FluentValidation.OpenApi - 62.3%
Rocket.Surgery.LaunchPad.AspNetCore.Testing - 47.2%
Rocket.Surgery.LaunchPad.EntityFramework - 29.3%
Rocket.Surgery.LaunchPad.Foundation - 43.3%
Rocket.Surgery.LaunchPad.Foundation.NewtonsoftJson - 64.4%
Rocket.Surgery.LaunchPad.Grpc - 41.1%
Rocket.Surgery.LaunchPad.Hosting - 48%
Rocket.Surgery.LaunchPad.Mapping - 38.3%
Rocket.Surgery.LaunchPad.Metadata - 49.7%
Rocket.Surgery.LaunchPad.Primitives - 71.6%
Rocket.Surgery.LaunchPad.Serilog - 60%
Rocket.Surgery.LaunchPad.Spatial - 59.3%
Rocket.Surgery.LaunchPad.Spatial.NewtonsoftJson - 37.2%
Rocket.Surgery.LaunchPad.StrawberryShake - 47.8%
Rocket.Surgery.LaunchPad.StrawberryShake.Spatial - 8.8%
Rocket.Surgery.LaunchPad.Telemetry - 20.8%
Rocket.Surgery.LaunchPad.Testing - 13.2%
Sample.BlazorServer - 5.2%
Sample.BlazorServer.Tests - 29%
Sample.BlazorWasm.Tests - 15.7%
Sample.Classic.Restful - 3.5%
Sample.Classic.Restful.Tests - 41%
Sample.Command.Tests - 16.3%
Sample.Core - 75.8%
Sample.Core.Tests - 55.3%
Sample.Graphql.Tests - 58.9%
Sample.Grpc - 73.2%
Sample.Grpc.Tests - 41.7%
Sample.Minimal - 16.2%
Sample.Minimal.Tests - 28%
Sample.Pages - 5.6%
Sample.Pages.Tests - 29.6%
Sample.Restful - 4%
Sample.Restful.Tests - 40%
Sample.Worker.Tests - 16.3%
|
109bca6 to
1240d25
Compare
1240d25 to
21b4aca
Compare
21b4aca to
22360c0
Compare
22360c0 to
bd5987f
Compare
c37d28a to
54bc43b
Compare
611ed7b to
33be495
Compare
33be495 to
7698369
Compare
ad51f33 to
dde69b8
Compare
76f74bf to
7a0b8a6
Compare
7a0b8a6 to
59af950
Compare
6b8d341 to
8c734fc
Compare
8c734fc to
ae6cabb
Compare
ae6cabb to
2b417e5
Compare
2b417e5 to
7bb2d6d
Compare
There was a problem hiding this comment.
Pull Request Overview
There is a critical misalignment between the pull request's stated intent and its implementation. While the title and description specify an update for dotnet-coverage to version 18, the actual changes modify the Alba package instead. The Microsoft.CodeCoverage dependency remains at version 17.14.1, meaning the primary objective of this PR has not been met.
Although Codacy analysis reports that the changes are technically up to standards, the logic error of updating the wrong dependency is a major blocker that must be addressed.
About this PR
- Major scope misalignment: The PR title and description claim to update 'dotnet-coverage' to v18, but the code diff shows an update for the 'Alba' package from 8.2.1 to 8.5.2 instead. The 'Microsoft.CodeCoverage' entry at line 161 remains at version 17.14.1.
Test suggestions
- Verify project builds and runs tests successfully with the updated dependency versions.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify project builds and runs tests successfully with the updated dependency versions.
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
| <PackageVersion Include="OpenTelemetry.Instrumentation.Runtime" Version="1.12.0" /> | ||
| <PackageVersion Include="OpenTelemetry.Instrumentation.AspNetCore" Version="1.12.0" /> | ||
| <PackageVersion Include="Alba" Version="8.2.1" /> | ||
| <PackageVersion Include="Alba" Version="8.5.2" /> |
There was a problem hiding this comment.
🔴 HIGH RISK
This change updates 'Alba' to 8.5.2, which contradicts the PR title and description stating that 'dotnet-coverage' should be updated to v18. The intended target was likely 'Microsoft.CodeCoverage' on line 161, which remains unchanged.
Up to standards ✅🟢 Issues
|
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
This PR contains the following updates:
17.14.2→18.8.0Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.