Skip to content

Update dependency Microsoft.CodeAnalysis.CSharp to v5#109

Closed
renovate[bot] wants to merge 1 commit into
mainfrom
renovate/major-roslyn
Closed

Update dependency Microsoft.CodeAnalysis.CSharp to v5#109
renovate[bot] wants to merge 1 commit into
mainfrom
renovate/major-roslyn

Conversation

@renovate

@renovate renovate Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Change Age Confidence
Microsoft.CodeAnalysis.CSharp 4.14.05.3.0 age confidence

Configuration

📅 Schedule: (UTC)

  • Branch creation
    • At any time (no schedule defined)
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate Bot added the 🚚 private-dependencies Private dependency label Jun 25, 2026
@github-actions github-actions Bot added the :shipit: merge Shipit! label Jun 25, 2026
@github-actions github-actions Bot added this to the v0.0.2 milestone Jun 25, 2026
@github-actions

github-actions Bot commented Jun 25, 2026

Copy link
Copy Markdown

Test Results

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit b1fddb6. ± Comparison against base commit 2429901.

♻️ This comment has been updated with latest results.

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.

Run reviewer

TIP This summary will be updated as you push new changes.

@codacy-production codacy-production Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

While the dependency update itself follows standard practices, it creates a direct conflict with the project's naming convention and apparent version-specific architecture. The project file Indago.Analyzers.roslyn4.8.csproj is explicitly named to reflect Roslyn 4.8 support, but the dependency is being moved to 5.3.0.

This misalignment should be resolved before merging. You must either rename the project and update its references to reflect version 5.x or revert the update if this project is strictly intended for 4.8 compatibility. Despite the Codacy analysis being 'up to standards', this naming contradiction represents a maintenance risk.

About this PR

  • There is a systemic naming inconsistency: the project is named 'roslyn4.8', but it is now being configured to use Roslyn 5.3.0. This suggests the project structure may need a broader update to support multiple Roslyn versions or a full migration to the newer version including file renaming.

Test suggestions

  • Verify project builds successfully with the updated Roslyn 5.3.0 dependency
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify project builds successfully with the updated Roslyn 5.3.0 dependency

TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback

</PropertyGroup>
<ItemGroup>
<PackageReference Include="Microsoft.CodeAnalysis.CSharp" VersionOverride="4.8.0" PrivateAssets="all" />
<PackageReference Include="Microsoft.CodeAnalysis.CSharp" VersionOverride="5.3.0" PrivateAssets="all" />

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 MEDIUM RISK

The package version (5.3.0) contradicts the project's filename 'Indago.Analyzers.roslyn4.8.csproj'. If this project is specifically intended to support Roslyn 4.8, this update should not be applied. However, if the project is migrating to version 5, the file should be renamed to reflect the new target version and all related solution and project references must be updated. Suggested action: Rename the project file to 'Indago.Analyzers.roslyn5.csproj' or similar and verify all dependent references.

@renovate renovate Bot force-pushed the renovate/major-roslyn branch from 81e0f14 to 1c02c46 Compare June 26, 2026 00:03
@github-actions github-actions Bot modified the milestones: v0.0.2, v0.0.3 Jun 26, 2026
@renovate renovate Bot force-pushed the renovate/major-roslyn branch from 1c02c46 to b1fddb6 Compare June 30, 2026 04:17
@github-actions github-actions Bot removed the :shipit: merge Shipit! label Jun 30, 2026
@renovate

renovate Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor Author

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future 5.x releases. But if you manually upgrade to 5.x then Renovate will re-enable minor and patch updates automatically.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@renovate renovate Bot deleted the renovate/major-roslyn branch June 30, 2026 05:02
@github-actions github-actions Bot removed this from the v0.0.3 milestone Jun 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🚚 private-dependencies Private dependency

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant