Update dependency Microsoft.CodeAnalysis.CSharp to v5

[renovate]

This PR contains the following updates:

Package	Change	Age	Confidence
Microsoft.CodeAnalysis.CSharp	4.14.0 → 5.3.0

---

Configuration

📅 Schedule: (UTC)

• Branch creation
  • At any time (no schedule defined)
• Automerge
  • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

---

• If you want to rebase/retry this PR, check this box

---

This PR was generated by Mend Renovate. View the repository job log.

[codacy-production]

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.

_{TIP This summary will be updated as you push new changes.}

[codacy-production]

Pull Request Overview

While the dependency update itself is technically straightforward, it introduces a significant logical inconsistency within the repository structure. The project file Rocket.Surgery.Conventions.Analyzers.roslyn4.14.csproj is explicitly named to indicate support for Roslyn 4.14. Upgrading it to 5.3.0 contradicts this intent.

This change should not be merged in its current state as it will likely break downstream consumers expecting 4.14 compatibility or create confusion regarding the project's purpose. Codacy analysis indicates the project otherwise remains up to standards.

About this PR

• The project file being updated is named 'roslyn4.14.csproj', which strongly implies it is intended to provide compatibility specifically for Microsoft.CodeAnalysis version 4.14. Upgrading it to 5.3.0 creates a significant mismatch between the file's stated purpose and its implementation.

Test suggestions

• Verify successful compilation of Rocket.Surgery.Conventions.Analyzers.roslyn4.14.csproj with the new dependency version.
• Verify that analyzer behavior remains compatible with the updated Roslyn compiler version.

Prompt proposal for missing tests

Consider implementing these tests if applicable:
1. Verify successful compilation of Rocket.Surgery.Conventions.Analyzers.roslyn4.14.csproj with the new dependency version.
2. Verify that analyzer behavior remains compatible with the updated Roslyn compiler version.

_{TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback}

[codacy-production]

_{🟡 MEDIUM RISK}

Updating the 'Microsoft.CodeAnalysis.CSharp' version to 5.3.0 contradicts the project's filename and intended compatibility with Roslyn 4.14. If this project is meant to support Roslyn 4.14 environments, this change should be reverted. If Roslyn 5 support is intended, a new project should be created or this one should be renamed to reflect the new target.

Suggested change

	<PackageReference Include="Microsoft.CodeAnalysis.CSharp" VersionOverride="5.3.0" PrivateAssets="all" />
	<PackageReference Include="Microsoft.CodeAnalysis.CSharp" VersionOverride="4.14.0" PrivateAssets="all" />

[github-actions]

Test Results

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit 92e6629. ± Comparison against base commit c15f555.