Skip to content

chore: remove endpoint from OpenAPI spec#203

Open
Verifieddanny wants to merge 1 commit intoRocketChat:mainfrom
Verifieddanny:remove-rooms-leave-openapi
Open

chore: remove endpoint from OpenAPI spec#203
Verifieddanny wants to merge 1 commit intoRocketChat:mainfrom
Verifieddanny:remove-rooms-leave-openapi

Conversation

@Verifieddanny
Copy link

@Verifieddanny Verifieddanny commented Feb 25, 2026

Remove endpoints from OpenAPI spec

The rooms.leave endpoint has been migrated to the new OpenAPI-compliant
pattern with AJV validation in the main Rocket.Chat repository.

Related PR: RocketChat/Rocket.Chat#38957 (merged)
Tracking PR: #150

@CLAassistant
Copy link

CLAassistant commented Feb 25, 2026

CLA assistant check
All committers have signed the CLA.

Copy link

@ahmed-n-abdeltwab ahmed-n-abdeltwab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ahmed-n-abdeltwab
Copy link

i think we need to change the branch from main to the branch that im working on #150

@ahmed-n-abdeltwab
Copy link

@ggazzo 👍

@Verifieddanny
Copy link
Author

Verifieddanny commented Feb 25, 2026

The branch you're working on, I believe is from your forked repo

And being compared to main branch on the OpenAPI repo

(do you suggest I clone your forked repo and push from there instead?)

@ahmed-n-abdeltwab
Copy link

The branch you're working on, I believe is from your forked repo

And being compared to main branch on the OpenAPI repo
(do you suggest I clone your forked repo and push from there instead?)

Personally, I don't mind that approach, but I suspect the maintainers would prefer us to create a dedicated branch within the main repository. That way, we can all merge our PRs into a single shared branch before the final merge into

@Verifieddanny
Copy link
Author

The branch you're working on, I believe is from your forked repo
And being compared to main branch on the OpenAPI repo
(do you suggest I clone your forked repo and push from there instead?)

Personally, I don't mind that approach, but I suspect the maintainers would prefer us to create a dedicated branch within the main repository. That way, we can all merge our PRs into a single shared branch before the final merge into

Ohh Alright, I think that approach is good, I will wait for the supposed branch to be created

@Verifieddanny
Copy link
Author

Hey @ahmed-n-abdeltwab , how do we move forward from here ?

Are you still creating a dedicated branch

@ahmed-n-abdeltwab
Copy link

Hey @ahmed-n-abdeltwab , how do we move forward from here ?

Are you still creating a dedicated branch

for now i recommend change the name instead of remove rooms.leave endpoint to remove endpoint. and until we get further clarification on their plans. We’re following the current instructions, so just keep updating this PR as you finish each API

@Verifieddanny
Copy link
Author

Alright, noted

@Verifieddanny Verifieddanny changed the title chore: remove rooms.leave endpoint from OpenAPI spec chore: remove endpoint from OpenAPI spec Feb 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants