Open
Conversation
Author
|
pene |
Contributor
|
Intenta compilar, eso te va generar un par de errores |
JorgePerC
reviewed
Mar 28, 2025
| #define HEADLIGHT_PIN GPIO_PIN_0 | ||
| #define MOTOR_PWM_PIN GPIO_PIN_1 | ||
|
|
||
| void pwm_init() { |
Contributor
There was a problem hiding this comment.
Está padre que se haga con registros directo... Pero recuerda que por cuestiones de modularidad, usamos los tim handlers del STM32
Ocupa esos, jeje
| TIM2->CR1 |= TIM_CR1_CEN; | ||
| } | ||
|
|
||
| void set_motor_speed(uint8_t duty_cycle) { TIM2->CCR2 = duty_cycle; } |
Contributor
There was a problem hiding this comment.
Esto también debería de ser a través del handler
| gpio_init(); | ||
| pwm_init(); | ||
|
|
||
| osThreadDef(THREAD_1, motor_control_task, osPriorityNormal, 0, configMINIMAL_STACK_SIZE); |
Contributor
There was a problem hiding this comment.
Esto está bien, sólo faltaría condicionar para que con el semaphore, se prenda y se apaque 👀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.