chore(site): add SVG favicon#13
Merged
Merged
Conversation
Adds a single-file SVG favicon at site/favicon.svg and the <link rel="icon"> reference in site/index.html. The browser tab was rendering with the default blank-document icon — small finish gap that read as half-baked. Design notes - 64x64 viewBox, ~330 bytes — single inline SVG, no external requests - Amber background (#b45309) matches the site --accent color exactly - Bold serif-less T glyph as the trove monogram (Geist would be ideal, but webfonts inside SVG favicons don't reliably load across browsers, so the T is drawn via two rects for crisp rendering at 16px) - Subtle baseline mark below the T — echoes the `~/.trove/` path underline shape from the ASCII banner aesthetic - Single file, no PNG fallback needed: SVG favicons are supported in Chrome 80+, Firefox 41+, Safari 9+ (covers Trove's target audience) - Cloudflare Pages serves /favicon.svg from site/ root automatically; the new auto-deploy workflow (PR #11/#12) will pick it up on next push Tested - Python ET parse: clean - Manually verified the link tag is in the head section between OG meta and the Google Fonts preconnect; CSS unaffected Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
XML 1.0 forbids '--' inside <!-- comments -->. The amber-accent comment contained 'site --accent #b45309' which made strict XML parsers reject the file. Browsers tolerate it but og:image renderers / Safari preview generators / CI image validators may not. Reworded the comment to 'matching the site accent (#b45309)' — same intent, no double-dash. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
site/favicon.svg+<link rel="icon">in<head>. Browser tab was showing the blank-document icon — small finish gap.--accent~/.trove/path underline--inside comments; reworded so strict parsers (Safari preview, og:image renderers) acceptAuto-deploy workflow (PR #11/#12) will pick it up on merge.
🤖 Generated with Claude Code