Add publish list management API and enhance report sharing models#76
Merged
Add publish list management API and enhance report sharing models#76
Conversation
- Updated the `share` method in `ReportClient` to accept a `publish_list_id` instead of a list of target graph IDs, aligning with the new sharing logic. - Modified the `ShareReportRequest` model to reflect the change from `target_graph_ids` to `publish_list_id`. - Added new fields `source_graph_id` and `entity_name` to `LedgerEntityResponse`, `ReportResponse`, and `SecurityResponse` models for improved data handling. - Updated `__init__.py` files to include new models and ensure proper exports. These changes enhance the report sharing capabilities and improve the overall data model structure for better integration and usability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Introduces a full-featured publish list management system for the ledger API and refactors the existing report sharing functionality with enhanced data models. This feature enables users to create, manage, and share reports via publish lists with granular member control.
Key Accomplishments
New Publish List API Endpoints (8 new modules)
robosystems_client/api/ledger/New & Enhanced Data Models (10 new/modified models)
PublishListResponse/PublishListDetailResponse/PublishListListResponse: Response models for publish list operations with varying levels of detailPublishListMemberResponse: Model for representing individual members within a publish listCreatePublishListRequest/UpdatePublishListRequest: Request models for publish list lifecycle managementAddMembersRequest: Request model for batch-adding members to a publish listUpdateSecurityRequest: New model for security update operationsLedgerEntityResponse,ReportResponse,SecurityResponse) with additional fields to support the publish list ecosystemRefactored Report Sharing
ShareReportRequestmodel to align with the new publish list architecturereport_client.pyextension to integrate with the refactored sharing flowBreaking Changes
ShareReportRequestmodel has been modified (fields changed/removed) — consumers relying on the previous structure will need to update their usageLedgerEntityResponse,ReportResponse, andSecurityResponsemodels have new fields, which may affect serialization/deserialization if strict schema validation is in placeTesting Notes
share_reportflow inreport_client.pyfunctions correctly with the updatedShareReportRequestmodelInfrastructure Considerations
🤖 Generated with Claude Code
Branch Info:
feature/share-reportmainCo-Authored-By: Claude noreply@anthropic.com