Remove deprecated mapping pages and streamline ledger navigation#95
Merged
Remove deprecated mapping pages and streamline ledger navigation#95
Conversation
…on, streamlining the codebase. Update trial balance content to link to the Chart of Accounts instead of Mappings for improved navigation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the legacy account mappings and mappings pages from the ledger section, eliminating ~1,865 lines of unused code. The trial balance page is updated to link to the Chart of Accounts instead of the now-removed Mappings page, providing a cleaner and more intuitive navigation flow.
Changes
Removed
/ledger/account-mappings— Deleted both the page and content component (890+ lines), which provided account mapping management UI/ledger/mappings— Deleted both the page and content component (680+ lines), which provided general mapping management UIsrc/lib/ledger/queries.ts— Removed 259 lines of associated query/data-fetching logic that exclusively served the deleted mapping pagesModified
src/app/(app)/ledger/trial-balance/content.tsx— Updated navigation link to point to Chart of Accounts instead of the removed Mappings pagesrc/lib/ledger/index.ts— Removed re-exports of deleted query functions to keep the module's public API cleanKey UI/UX Improvements
Breaking Changes
/ledger/account-mappings/ledger/mappingsAny bookmarks, external links, or internal references pointing to these routes will result in a 404. If there are other parts of the application (e.g., sidebar navigation, breadcrumbs, or other page links) that reference these routes, they should be verified and updated accordingly.
Additionally, any consumers importing from
src/lib/ledgerthat relied on the removed query functions will encounter build errors.Testing Notes
/ledger/account-mappingsor/ledger/mappingsexist in navigation menus, sidebars, or other componentsnext build) to ensure no broken imports fromsrc/lib/ledgerqueries.ts)Browser Compatibility
No browser compatibility concerns — this PR only removes pages and updates a link href. No new browser APIs, CSS features, or client-side behavior is introduced.
🤖 Generated with Claude Code
Branch Info:
refactor/cleanup-old-mapping-pagesmainCo-Authored-By: Claude noreply@anthropic.com