Repository navigation
dashboard: 'Not sent (suppressed)' in send history for suppression-blocked sends - #58
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
On a message page, the "More to " send-history panel printed each row's raw status. A re-send blocked before sending (status
suppressed) sat in a list of real bounces and read as one more failed delivery. It now reads Not sent (suppressed).Also on the blocked message's own record, the stop on the line was described as "provider feedback". A suppression block never reaches a provider, so it now says "blocked before sending". Real bounces, complaints and failures still say "provider feedback".
Root cause
Display only. The stored data already distinguishes the cases: the API and worker set
messages.status = 'suppressed'and write asuppressedaudit event (apps/api/src/routes/messages.ts, apps/worker/src/pipeline.ts ~L279). The panel rendered{m.status}with CSScapitalize, andeventsFrom()hard-coded "provider feedback" for any stop.Change
apps/dashboard/src/lib/send-history-label.ts(sendHistoryLabel,stopMethod).message-card.tsx: the panel usessendHistoryLabel(m.status).live-status.tsx: the stopped station usesstopMethod(message.status).Tests
send-history-label.test.ts: a regression test for suppressed, plus characterization tests showing every other status keeps its previous capitalised wording (Bounced, Complained, Delivered, Sent, Failed, Queued) and real stops still say "provider feedback".Configs touched
None. No env, migrations, worker, API or infra changes.
Prod behaviour preserved
suppressedrenders exactly as before, so real bounces still show "Bounced".