Skip to content

refactor: centralize string normalization with trim_lower macro - #36

Merged
Ritik574-coder merged 1 commit into
mainfrom
dbt_branch
Jul 20, 2026
Merged

refactor: centralize string normalization with trim_lower macro#36
Ritik574-coder merged 1 commit into
mainfrom
dbt_branch

Conversation

@Ritik574-coder

Copy link
Copy Markdown
Owner

Summary

Introduced a reusable trim_lower macro to centralize string normalization logic across intermediate models. This removes duplicated LOWER(TRIM(...)) expressions, improves code readability, and makes future maintenance easier.

Changes made

  • Added a reusable trim_lower macro in macros/trim_lower.sql
  • Replaced repeated LOWER(TRIM(...)) expressions with the new macro
  • Refactored customer, employee, inventory, product, return, review, and store intermediate models
  • Improved code consistency and maintainability
  • Updated .gitignore

Validation

  • Commands tested locally (if applicable)
  • Docs links checked
  • No secrets committed
  • CI passes

Related issues

N/A

Notes for reviewers

This is a refactoring change only. No business logic has been modified. The macro simply replaces repeated string normalization expressions, making the project easier to maintain and reducing code duplication.

@Ritik574-coder Ritik574-coder left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

improve readability by extracting trim_lower macro

@Ritik574-coder
Ritik574-coder merged commit b238387 into main Jul 20, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant