refactor: centralize string normalization with trim_lower macro - #36
Merged
Conversation
Ritik574-coder
commented
Jul 20, 2026
Ritik574-coder
left a comment
Owner
Author
There was a problem hiding this comment.
improve readability by extracting trim_lower macro
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Introduced a reusable
trim_lowermacro to centralize string normalization logic across intermediate models. This removes duplicatedLOWER(TRIM(...))expressions, improves code readability, and makes future maintenance easier.Changes made
trim_lowermacro inmacros/trim_lower.sqlLOWER(TRIM(...))expressions with the new macro.gitignoreValidation
Related issues
N/A
Notes for reviewers
This is a refactoring change only. No business logic has been modified. The macro simply replaces repeated string normalization expressions, making the project easier to maintain and reducing code duplication.