Added support for 8ch.net and yuki.la in ChanRipper.java#327
Open
infamix wants to merge 1 commit intoRipMeApp:mainfrom
infamix:master
Open
Added support for 8ch.net and yuki.la in ChanRipper.java#327infamix wants to merge 1 commit intoRipMeApp:mainfrom infamix:master
infamix wants to merge 1 commit intoRipMeApp:mainfrom
infamix:master
Conversation
cyian-1756
requested changes
Dec 9, 2017
| return url.toExternalForm().contains("/res/") // Most chans | ||
| || url.toExternalForm().contains("/thread/"); // 4chan, archive.moe | ||
| || url.toExternalForm().contains("/thread/") // 4chan, archive.moe | ||
| || url.toExternalForm().contains("/"); // yuki.la, etc |
Collaborator
There was a problem hiding this comment.
|| url.toExternalForm().contains("/"); // yuki.la, etc is way to greedy. Try changing it to a regex that will only match yuki.la links.
|
I have a request and I didn't want to make a new request thread. But would it be possible to add way to download images/videos with original image names instead of numbers? DL from
@infamix also a ripper for 4plebs.org would be great. |
Collaborator
Yea it could. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category
This change is exactly one of the following (please change
[ ]to[x]) to indicate which:Description
I've added support for 8chan (8ch.net) and yuki.la 4chan archive threads in ChanRipper,
which were missing.
Testing
Required verification:
mvn test(there are no new failures or errors).Optional but recommended: