Repository navigation
fix(publish): pack the full internal closure with rewritten specifiers - #11
Merged
Merged
Conversation
The umbrella tarball only shipped a hardcoded package list and relied on a non-"#" imports map that Bun alone resolves, so Node/vitest consumers failed on every @opencode/* specifier. Compute the closure from runtime src/ imports, honor each package's own exports map (exact, wildcard with longest-prefix precedence, asset paths), and rewrite internal specifiers to relative paths at pack time. Drop the unused Actors surface and its @rivetkit/effect dependency from packages/rivet.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
|
The following comment was made by an LLM, it may be inaccurate: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/imports instead of a hardcoded list (23 packages, includingai,tui,theme,codemode,simulation,plugin-browser)@opencode/*specifiers to relative paths at pack time so the tarball resolves under Node/vitest, not only Bunexportsmap: exact keys, wildcard keys with longest-prefix precedence, and direct asset targets like./audio/*.mp3src/+package.jsonper internal packageActorssurface and@rivetkit/effectdependency frompackages/rivetTest plan
OPENCODE_VERSION=9.9.9-test bun ./script/publish-rikalabs.tspacks cleanly; no remaining@opencode/*runtime specifiers in the tarballfile:— lint, typecheck, db check, and full@whorl/actorssuite (sql + postgres + process) pass against itbun run checkgreen (38 typecheck tasks, 0 lint warnings)Generated with Devin