Skip to content

Add CI build job to reduce broken main#969

Open
randavidovitz wants to merge 3 commits intoRightNow-AI:mainfrom
randavidovitz:ci/add-build-job
Open

Add CI build job to reduce broken main#969
randavidovitz wants to merge 3 commits intoRightNow-AI:mainfrom
randavidovitz:ci/add-build-job

Conversation

@randavidovitz
Copy link
Copy Markdown

Summary

  • Add build job to CI that runs cargo build --workspace --lib on all 3 platforms (ubuntu, macos, windows)
  • This catches compilation/linker errors before merge, preventing broken builds from being merged
  • Fix formatting issues
  • Fix audit critical issues (manual upgrade until handle by parent dependency)
  • Fix compilation issues related to xxx ( fixes Not compiling #959 )

Why

Previously CI only ran cargo check (type-level validation). Actual compilation errors could slip through. This ensures the code actually compiles before merging.

Testing

  • Verify CI passes on this PR
  • cargo clippy --workspace --all-targets -- -D warnings passes
  • cargo test --workspace passes
  • Live integration tested (if applicable)

Security

  • No new unsafe code
  • No secrets or API keys in diff
  • User input validated at boundaries

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Not compiling

1 participant