Skip to content

[GRV-38]: fix Linear team selections #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
github-actions merged 1 commit into from
Jun 7, 2026
+45 −23
Merged

[GRV-38]: fix Linear team selections #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions packages/human-handoff-linear/src/adapters/linear-graphql-workspace.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ export function createLinearGraphqlWorkspace({
const data = await graphql(
`query Labels($teamId: ID, $first: Int!, $after: String) {
issueLabels(first: $first, after: $after, filter: { team: { id: { eq: $teamId } } }) {
nodes { id name color teamId description }
nodes { id name color team { id } description }
pageInfo { hasNextPage endCursor }
}
}`,
Expand All @@ -162,7 +162,7 @@ export function createLinearGraphqlWorkspace({
id: l.id,
name: l.name,
color: l.color,
teamId: l.teamId,
teamId: l.team?.id ?? null,
description: l.description ?? null,
})) ?? []));
if (page?.pageInfo?.hasNextPage !== true) break;
Expand All @@ -178,7 +178,7 @@ export function createLinearGraphqlWorkspace({
`mutation CreateLabel($input: IssueLabelCreateInput!) {
issueLabelCreate(input: $input) {
success
issueLabel { id name color teamId description }
issueLabel { id name color team { id } description }
}
}`,
{ input: { teamId, name, color, description } },
Expand All @@ -191,7 +191,7 @@ export function createLinearGraphqlWorkspace({
id: result.issueLabel.id,
name: result.issueLabel.name,
color: result.issueLabel.color,
teamId: result.issueLabel.teamId,
teamId: result.issueLabel.team?.id ?? null,
description: result.issueLabel.description ?? null,
};
},
Expand All @@ -200,7 +200,7 @@ export function createLinearGraphqlWorkspace({
if (id) {
const data = await graphql(
`query Template($id: String!) {
template(id: $id) { id name description type teamId }
template(id: $id) { id name description type team { id } }
}`,
{ id },
);
Expand All @@ -213,7 +213,7 @@ export function createLinearGraphqlWorkspace({
const data = await graphql(
`query TeamTemplates($teamId: String!) {
team(id: $teamId) {
templates { nodes { id name description type teamId } }
templates { nodes { id name description type team { id } } }
}
}`,
{ teamId },
Expand All @@ -227,11 +227,11 @@ export function createLinearGraphqlWorkspace({
// same-named team template does not shadow a missing workspace one.
const data = await graphql(
`query WorkspaceTemplates {
templates { id name description type teamId }
templates { id name description type team { id } }
}`,
);
const nodes = Array.isArray(data?.templates) ? data.templates : [];
const match = nodes.find((n) => n.name === name && n.type === 'issue' && !n.teamId);
const match = nodes.find((n) => n.name === name && n.type === 'issue' && !n.team?.id);
return match ? normalizeTemplate(match) : null;
},

Expand All @@ -243,7 +243,7 @@ export function createLinearGraphqlWorkspace({
`mutation CreateTemplate($input: TemplateCreateInput!) {
templateCreate(input: $input) {
success
template { id name description type teamId }
template { id name description type team { id } }
}
}`,
{ input },
Expand All @@ -264,7 +264,7 @@ export function createLinearGraphqlWorkspace({
`mutation UpdateTemplate($id: String!, $input: TemplateUpdateInput!) {
templateUpdate(id: $id, input: $input) {
success
template { id name description type teamId }
template { id name description type team { id } }
}
}`,
{ id, input },
Expand Down Expand Up @@ -453,7 +453,7 @@ function normalizeTemplate(t) {
name: t.name,
description: t.description ?? null,
type: t.type,
teamId: t.teamId,
teamId: t.team?.id ?? null,
};
}

Expand Down
46 changes: 34 additions & 12 deletions packages/human-handoff-linear/tests/linear-graphql-workspace.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,16 @@ function recordingFetch(responder) {
return fn;
}

function assertUsesTeamObjectSelection(query) {
const compact = query.replace(/\s+/g, ' ');
assert.match(compact, /\bteam\s*\{\s*id\s*\}/, 'query should select team { id }');
assert.doesNotMatch(
compact,
/\b(?:issueLabel|template|templates|nodes)\s*\{[^{}]*\bteamId\b/,
'query should not select scalar teamId from IssueLabel or Template response objects',
);
}

test('createLinearGraphqlWorkspace throws MissingTokenError when apiKey is empty', () => {
assert.throws(() => createLinearGraphqlWorkspace({ apiKey: '', fetch: async () => jsonResponse({}) }), MissingTokenError);
assert.throws(() => createLinearGraphqlWorkspace({ apiKey: undefined, fetch: async () => jsonResponse({}) }), MissingTokenError);
Expand Down Expand Up @@ -201,26 +211,30 @@ test('listTeams returns normalized teams', async () => {

test('listLabels passes the teamId variable to the GraphQL query', async () => {
const fetch = recordingFetch(() => jsonResponse({
data: { issueLabels: { nodes: [{ id: 'l1', name: 'foundation', color: '#fff', teamId: 't1', description: null }] } },
data: { issueLabels: { nodes: [{ id: 'l1', name: 'foundation', color: '#fff', team: { id: 't1' }, description: null }] } },
}));
const ws = createLinearGraphqlWorkspace({ apiKey: FAKE_KEY, fetch });
const labels = await ws.listLabels({ teamId: 't1' });
const body = JSON.parse(fetch.calls[0].init.body);
assert.equal(body.variables.teamId, 't1');
assertUsesTeamObjectSelection(body.query);
assert.equal(labels.length, 1);
assert.equal(labels[0].name, 'foundation');
assert.equal(labels[0].teamId, 't1');
});

test('createLabel posts the input and returns the created label', async () => {
const fetch = recordingFetch(() => jsonResponse({
data: { issueLabelCreate: { success: true, issueLabel: { id: 'l9', name: 'human-handoff', color: '#f00', teamId: 't1', description: 'handoff' } } },
data: { issueLabelCreate: { success: true, issueLabel: { id: 'l9', name: 'human-handoff', color: '#f00', team: { id: 't1' }, description: 'handoff' } } },
}));
const ws = createLinearGraphqlWorkspace({ apiKey: FAKE_KEY, fetch });
const label = await ws.createLabel({ teamId: 't1', name: 'human-handoff', color: '#f00', description: 'handoff' });
const body = JSON.parse(fetch.calls[0].init.body);
assert.equal(body.variables.input.name, 'human-handoff');
assert.equal(body.variables.input.teamId, 't1');
assertUsesTeamObjectSelection(body.query);
assert.equal(label.id, 'l9');
assert.equal(label.teamId, 't1');
assert.equal(label.description, 'handoff');
});

Expand All @@ -237,22 +251,25 @@ test('createLabel maps success:false → LinearApiError', async () => {
});

test('getTemplate by id returns null when not found', async () => {
const fetch = async () => jsonResponse({ data: { template: null } });
const fetch = recordingFetch(() => jsonResponse({ data: { template: null } }));
const ws = createLinearGraphqlWorkspace({ apiKey: FAKE_KEY, fetch });
assert.equal(await ws.getTemplate({ id: 'missing' }), null);
const body = JSON.parse(fetch.calls[0].init.body);
assertUsesTeamObjectSelection(body.query);
});

test('getTemplate by teamId + name searches team templates', async () => {
const fetch = recordingFetch(() => jsonResponse({
data: { team: { templates: { nodes: [
{ id: 'tpl_a', name: 'Other', description: '', type: 'issue', teamId: 't1' },
{ id: 'tpl_b', name: 'Human Handoff', description: 'body', type: 'issue', teamId: 't1' },
{ id: 'tpl_a', name: 'Other', description: '', type: 'issue', team: { id: 't1' } },
{ id: 'tpl_b', name: 'Human Handoff', description: 'body', type: 'issue', team: { id: 't1' } },
] } } },
}));
const ws = createLinearGraphqlWorkspace({ apiKey: FAKE_KEY, fetch });
const tpl = await ws.getTemplate({ teamId: 't1', name: 'Human Handoff' });
const body = JSON.parse(fetch.calls[0].init.body);
assert.equal(body.variables.teamId, 't1');
assertUsesTeamObjectSelection(body.query);
assert.deepEqual(tpl, { id: 'tpl_b', name: 'Human Handoff', description: 'body', type: 'issue', teamId: 't1' });
});

Expand All @@ -265,23 +282,24 @@ test('getTemplate without id/teamId+name throws TypeError', async () => {
test('getTemplate by name (no teamId) finds the workspace-level template', async () => {
const fetch = recordingFetch(() => jsonResponse({
data: { templates: [
{ id: 'tpl_a', name: 'Bug Report', description: '', type: 'issue', teamId: 't1' },
{ id: 'tpl_b', name: 'Human Handoff', description: 'body', type: 'issue', teamId: null },
{ id: 'tpl_c', name: 'Human Handoff', description: 'team body', type: 'issue', teamId: 't1' },
{ id: 'tpl_a', name: 'Bug Report', description: '', type: 'issue', team: { id: 't1' } },
{ id: 'tpl_b', name: 'Human Handoff', description: 'body', type: 'issue', team: null },
{ id: 'tpl_c', name: 'Human Handoff', description: 'team body', type: 'issue', team: { id: 't1' } },
] },
}));
const ws = createLinearGraphqlWorkspace({ apiKey: FAKE_KEY, fetch });
const tpl = await ws.getTemplate({ name: 'Human Handoff' });
const body = JSON.parse(fetch.calls[0].init.body);
assert.match(body.query, /templates/);
assert.equal(body.variables ?? undefined, undefined);
assertUsesTeamObjectSelection(body.query);
assert.deepEqual(tpl, { id: 'tpl_b', name: 'Human Handoff', description: 'body', type: 'issue', teamId: null });
});

test('getTemplate by name returns null when no workspace template matches', async () => {
const fetch = async () => jsonResponse({
data: { templates: [
{ id: 'tpl_c', name: 'Human Handoff', description: '', type: 'issue', teamId: 't1' },
{ id: 'tpl_c', name: 'Human Handoff', description: '', type: 'issue', team: { id: 't1' } },
] },
});
const ws = createLinearGraphqlWorkspace({ apiKey: FAKE_KEY, fetch });
Expand All @@ -290,13 +308,14 @@ test('getTemplate by name returns null when no workspace template matches', asyn

test('createTemplate without teamId creates a workspace-level template', async () => {
const fetch = recordingFetch(() => jsonResponse({
data: { templateCreate: { success: true, template: { id: 'tpl_w', name: 'Human Handoff', description: 'd', type: 'issue', teamId: null } } },
data: { templateCreate: { success: true, template: { id: 'tpl_w', name: 'Human Handoff', description: 'd', type: 'issue', team: null } } },
}));
const ws = createLinearGraphqlWorkspace({ apiKey: FAKE_KEY, fetch });
const tpl = await ws.createTemplate({ name: 'Human Handoff', description: 'd' });
const body = JSON.parse(fetch.calls[0].init.body);
assert.equal(body.variables.input.name, 'Human Handoff');
assert.equal(body.variables.input.teamId, undefined, 'teamId is omitted for workspace-level');
assertUsesTeamObjectSelection(body.query);
assert.equal(tpl.teamId, null);
});

Expand All @@ -308,24 +327,27 @@ test('createTemplate requires { name }', async () => {

test('createTemplate posts input and returns normalized template', async () => {
const fetch = recordingFetch(() => jsonResponse({
data: { templateCreate: { success: true, template: { id: 'tpl_new', name: 'Human Handoff', description: 'd', type: 'issue', teamId: 't1' } } },
data: { templateCreate: { success: true, template: { id: 'tpl_new', name: 'Human Handoff', description: 'd', type: 'issue', team: { id: 't1' } } } },
}));
const ws = createLinearGraphqlWorkspace({ apiKey: FAKE_KEY, fetch });
const tpl = await ws.createTemplate({ teamId: 't1', name: 'Human Handoff', description: 'd' });
const body = JSON.parse(fetch.calls[0].init.body);
assert.equal(body.variables.input.type, 'issue');
assertUsesTeamObjectSelection(body.query);
assert.equal(tpl.id, 'tpl_new');
assert.equal(tpl.teamId, 't1');
});

test('updateTemplate posts only the supplied fields', async () => {
const fetch = recordingFetch(() => jsonResponse({
data: { templateUpdate: { success: true, template: { id: 'tpl_1', name: 'Human Handoff', description: 'next', type: 'issue', teamId: 't1' } } },
data: { templateUpdate: { success: true, template: { id: 'tpl_1', name: 'Human Handoff', description: 'next', type: 'issue', team: { id: 't1' } } } },
}));
const ws = createLinearGraphqlWorkspace({ apiKey: FAKE_KEY, fetch });
await ws.updateTemplate({ id: 'tpl_1', description: 'next' });
const body = JSON.parse(fetch.calls[0].init.body);
assert.equal(body.variables.id, 'tpl_1');
assert.deepEqual(body.variables.input, { description: 'next' });
assertUsesTeamObjectSelection(body.query);
});

test('updateTemplate without id throws TypeError', async () => {
Expand Down
Loading