Repository navigation
fix: preserve publish, mount mode, and entrypoint args - #60
Merged
Merged
Conversation
container run was dropping the host IP, protocol, and read-only bit, and joining entrypoint elements into one string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--publishkeeps the host IP and a non-TCP protocol (127.0.0.1:8080:80,5353:53/udp). IPv6 host addresses are bracketed.:rowhen the compose mount is read-only.--entrypointand prepends the rest to the command.Test plan
go test ./internal/backend/ ./cmd/ ./internal/compose/(99 passed)up --dry-runon a compose file with a host IP, UDP, a read-only bind, andentrypoint: ["sh","-c",...]apple-compose up --force-recreateonce on any stack that uses these fields. The config hash does not include them, so a normalupwill not recreate an existing container.