Conversation
첨삭 버전 목록과 상세 조회 API를 추가하고 현재 사용자 소유 검증, 최신 버전 판정, 문항별 결과 응답을 처리한다.
7 tasks
📝 WalkthroughWalkthrough
ChangesReviewVersion 목록/상세 조회 API 구현
Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Comment |
Backend CI Report
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/test/java/com/daon/rewrite/reviewversion/repository/ReviewVersionRepositoryTest.java (1)
102-108: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value
version필드를 리플렉션으로 강제 변경하는 의도를 명확히 하면 좋겠습니다.
ReviewVersion.first(...)로 만든newVersion의version을ReflectionTestUtils.setField로v0.2로 덮어쓰고 있는데, 이 테스트는createdAt내림차순 정렬만 검증하므로version값 자체는 단언에 사용되지 않습니다.(coverLetter, version)유니크 제약 회피 등 도메인 제약 때문이라면 짧은 주석을 남기거나, 도메인에 다음 버전 생성용 팩토리가 있다면 그쪽을 사용하는 편이 내부 상태 의존을 줄여 더 견고합니다.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/test/java/com/daon/rewrite/reviewversion/repository/ReviewVersionRepositoryTest.java` around lines 102 - 108, The test in ReviewVersionRepositoryTest is mutating the ReviewVersion.version field via ReflectionTestUtils without making the reason explicit. Clarify the intent by either switching to an existing next-version factory or adding a short inline comment near ReviewVersion.first(...) / ReflectionTestUtils.setField(...) explaining that the override is only to satisfy the domain constraint (for example, the coverLetter/version uniqueness) and is not part of the assertion, so the test remains readable and less dependent on internal state.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In
`@src/test/java/com/daon/rewrite/reviewversion/repository/ReviewVersionRepositoryTest.java`:
- Around line 102-108: The test in ReviewVersionRepositoryTest is mutating the
ReviewVersion.version field via ReflectionTestUtils without making the reason
explicit. Clarify the intent by either switching to an existing next-version
factory or adding a short inline comment near ReviewVersion.first(...) /
ReflectionTestUtils.setField(...) explaining that the override is only to
satisfy the domain constraint (for example, the coverLetter/version uniqueness)
and is not part of the assertion, so the test remains readable and less
dependent on internal state.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: af47036d-213b-45d7-9ee0-092f6a1e36e6
📒 Files selected for processing (14)
docs/api/README.mddocs/status.mdsrc/main/java/com/daon/rewrite/reviewversion/controller/ReviewVersionController.javasrc/main/java/com/daon/rewrite/reviewversion/dto/ReviewVersionDetailResponse.javasrc/main/java/com/daon/rewrite/reviewversion/dto/ReviewVersionListItemResponse.javasrc/main/java/com/daon/rewrite/reviewversion/dto/ReviewVersionListResponse.javasrc/main/java/com/daon/rewrite/reviewversion/dto/ReviewVersionQuestionResultResponse.javasrc/main/java/com/daon/rewrite/reviewversion/repository/ReviewVersionRepository.javasrc/main/java/com/daon/rewrite/reviewversion/service/ReviewVersionDetail.javasrc/main/java/com/daon/rewrite/reviewversion/service/ReviewVersionQueryService.javasrc/main/java/com/daon/rewrite/reviewversion/service/ReviewVersionSummary.javasrc/test/java/com/daon/rewrite/reviewversion/controller/ReviewVersionControllerTest.javasrc/test/java/com/daon/rewrite/reviewversion/repository/ReviewVersionRepositoryTest.javasrc/test/java/com/daon/rewrite/reviewversion/service/ReviewVersionQueryServiceTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
작업 내용
CoverLetter.latestReviewVersionId기준으로 계산합니다.questionOrder오름차순으로 반환합니다.관련 이슈
문서 반영
docs/api/README.mddocs/status.md확인 결과
./gradlew test./gradlew checkgit diff --checkSummary by CodeRabbit
New Features
Bug Fixes
Documentation
Tests