Repository navigation
chore: make main knip-clean - #4502
Merged
Merged
Conversation
Drop the export from 33 symbols used only in their own file, delete three unused wire types, and stop re-exporting three types from package indexes no consumer imports through. No behaviour change. Co-authored-by: luke-agent[bot] <339870089+luke-agent[bot]@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
payer-model.ts was deleted on main, which settles its PayerOption finding. Co-authored-by: luke-agent[bot] <339870089+luke-agent[bot]@users.noreply.github.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Oct 21, 2026
Take main's cloud-browser-tabs.ts, keep AgentBrowserTabCursor and TaskBrowserTabsLiveAnswer exported now that #4399 imports them, and drop the export from four more file-local symbols knip found after the merge. Co-authored-by: luke-agent[bot] <339870089+luke-agent[bot]@users.noreply.github.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pnpm kniponmain(56bb758) reported 39 unused exports. This makes it clean again, with no behaviour change: every symbol below is still used in its own file, except the three deleted types, which nothing used at all.Each finding names the PR that last changed that symbol's uses, which is where it went unused, or, for the oldest two, where it was last touched.
Export dropped (used only in its own file)
RUNTIME_CHOICE_REFUSALpackages/features/src/agent-runtime-models.tsbrowserLiveTargetSchemapackages/features/src/browser-live-acts.tscodingAgentMessageAnswerViewSchemapackages/features/src/coding-agent-view.tscodingAgentTranscriptPageSchemapackages/features/src/coding-agent-view.tscodingAgentInboxAnswerViewSchemapackages/features/src/coding-agent-view.tsinboxAskSchemapackages/features/src/inbox-wire.tsChatGptSave,ChatGptSignInRequestpackages/credentials/src/chatgpt-sign-in.tsATTACH_FILESpackages/panel/src/tasks/attach-files-button.tsxCLOUD_BROWSER_RECONNECT,CLOUD_BROWSER_VIEWPORT_EVERY,CloudBrowserPhasepackages/panel/src/tasks/cloud-browser-live.tsCLAUDE_PLAN_REFUSALpackages/panel/src/tasks/coding-agent-model.tsTURN_READpackages/panel/src/tasks/coding-agent-model.tsattachedAnswerspackages/panel/src/tasks/inbox-model.tsCLAUDE_PLAN_LABEL_WORDSpackages/panel/src/tasks/plan-label-model.tswindowTranscriptOlderpackages/panel/src/tasks/use-agent-transcript.tsPanelSpanName,PanelSpanAttributepackages/panel/src/panel-spans.tsMessageBringerpackages/panel/src/tasks/agent-tab.tsxPLAN_AGENT_WRITER_POLICYpackages/service/src/agents/agent-reach.tsnativeCoderInstructionspackages/service/src/agents/coder-host/native-agent-sessions.tsISSUING,UNCONFIGURED,LINEAR_TOOLSpackages/service/src/testing/integration-mcp-fake.tsConnectionRefusalpackages/service/src/integrations/connection-door.tsRunningPagepackages/service/src/agents/vercel-sandbox-api.tsHeardCallpackages/service/src/testing/native-relay-fake.tsPendingStatuspackages/ui/src/tasks-model.tsHeardTailpackages/voice/src/transcript-model.tsHELD_BYTESpackages/host/src/transcript-held.tsTRANSCRIPT_LOADING_LABEL,ComposerSkeletonpackages/panel/src/tasks/agent-tab-skeleton.tsxCLOUD_BROWSER_CURSOR_IDLEpackages/panel/src/tasks/cloud-browser-cursor.tsxDeleted (unused anywhere)
BrowserLivePortInboundpackages/features/src/browser-live-acts.tsProviderKeyForAgentsRequestpackages/features/src/provider-key-wire.tsRe-export dropped from a package index (consumers import the module directly)
HostTerminalPort,TerminalActsDependenciespackages/host/src/act-port/index.tsTypedRowWritepackages/voice/src/live-session/index.tsThe other files sharing a name (
UNCONFIGUREDin two tests,HeardCallandTypedRowWritein@luke/voiceand@luke/database) declare their own symbols and never import these. None is reached through a dynamic import or a package entry, soknip.jsondoesn't change.PayerOption(packages/panel/src/tasks/payer-model.ts, from #4334) was on the list too, butmainhas since deleted that file. Mergingmainin settled it, andpnpm knipstayed clean after the merge.A second merge of
mainsettled three more: #4399 now importsAgentBrowserTabCursorandTaskBrowserTabsLiveAnswer, so those keep their exports, and it removedCLOUD_BROWSER_TABS_EVERYitself. The four symbols from #4486, #4497 and #4399 were new findings after that merge.Checks:
pnpm knippasses on this branch. Runningpnpm check:affectedhere, every@luke/featurestest passed (389 of 389), but vitest timed out starting its fork workers because the sandbox was short on resources, so CI is the gate for the rest. After the second merge,tsc --noEmitpasses for features, panel, host, service, voice, credentials and ui.Made with Luke