Repository navigation
fix(service): a Start answers the last transaction it committed in - #4453
Merged
Merged
Conversation
A Start inserts the agent, then moves its task into progress and assigns it in transactions of their own, and a task started with an agent commits the task before the agent. The answer now carries the last of them: Realtime delivers transactions in commit order, so a client that waits on it sees the agent and its task's standing alike. Co-authored-by: luke-agent[bot] <339870089+luke-agent[bot]@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #4431, which entered the merge queue before this fix to Devin's review comment (thread) could be pushed.
A Start inserts the agent, then moves its task into progress (
beginTaskWork) and assigns it (assignUnassignedTask), each in its own transaction. A task started with an agent also commits the task before the agent. Before this fix, the answer carried the first txid, so a client waiting on it could confirm before the agent and the task's new standing reached the followed list.Now:
beginTaskWorkCommittedandassignUnassignedTaskCommittedreturn their txid in their ownRETURNING, and none where nothing moved. The boolean functions stay as they were.startCodingAgentanswers the last txid it committed.Realtime delivers transactions in commit order, so waiting on the last one covers every earlier one.
Tests:
task-list-live.test.tschecks that both writes return their own, increasing txid and that asking again returns none.coding-agents-app.test.tschecks that a task's start with an agent answers the task row'sxmin, which is its last write.Made with Luke