Repository navigation
fix(host): a workspace's people seal that fails for now no longer empties the window's list - #4347
Merged
Merged
Conversation
…ties the window's list The people follow told the window every seal refusal, a passing one among them, and the window drew a refusal as no people: the members and the ownership controls drawn from them went until the next push. Only a workspace the account is not in is told now; a seal that fails for now is asked again on the backoff without a word, so the window keeps the people it holds, its own first read covering a list never answered. Co-authored-by: luke-agent[bot] <339870089+luke-agent[bot]@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to Devin's review of #3942 (thread).
The host's people follow told the window every seal refusal, including passing ones such as
unanswered. The window drew any refusal as no people, so the members (and the Transfer ownership controls drawn from them) disappeared until the next push.The host now tells only a workspace the account is not in (
not-found). A seal that fails for now is retried on the backoff without telling the window, so the window keeps the people it holds. If the list was never answered, the window's own first read covers it.Test:
compose-tasks.test.tsfails the people seal for a while. No refusal reaches the window, and the seal is asked again. Without the fix the test fails.The invitations follow that #3956 adds shares this code, so it gets the same behavior when that PR rebases.
Made with Luke