Repository navigation
fix(host): a workspace's people stream opened as the last one closes keeps its follow - #4346
Merged
Merged
Conversation
…keeps its follow The act port counted a workspace's people streams and asked the host to follow or unfollow outside any turn, so a last stream's unfollow still on its way could land after a new stream's follow and take that follow away, the new stream left open with no word reaching it. Each count change and its ask of the host now take the workspace's turn, as the chat's streams do, so the unfollow always reaches the host first. Co-authored-by: luke-agent[bot] <339870089+luke-agent[bot]@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to Devin's review of #3942 (thread).
The act port counted each workspace's people streams and asked the host to follow or unfollow outside any turn. So if the last stream's unfollow was still on its way when a new stream opened, the unfollow could land after the new follow and take it away. The new stream stayed open, but nothing reached it.
Each count change and its ask of the host now take the workspace's turn (one semaphore per workspace), as
chatChangesinagent-inbox-procedures.tsalready does. The unfollow always reaches the host first.Test:
workspace-procedures.test.tsopens a stream while the last one's unfollow is held. The new follow is asked only once the unfollow is done. Without the fix the test fails.The invitations stream that #3956 adds goes through the same helper, so it gets the same guard when that PR rebases.
Made with Luke