Repository navigation
fix(host): a followed automation that is deleted is told not found at once - #4342
Merged
Merged
Conversation
… once When a renewal or a poll of a followed automation's runs came back not found, the follow ended in `liveRows` as gone, but the host follow restarted it five seconds later and only then told the page. It now ends at once on gone: not found is told to the page, and a signed-out session ends it unsaid. Co-authored-by: luke-agent[bot] <339870089+luke-agent[bot]@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
…nswers after it A poll and a renewal may run side by side while Realtime falls back, so a later success could clear the not-found that ended the follow, and the page was never told. The follow now keeps the first not-found or signed-out it meets. Co-authored-by: luke-agent[bot] <339870089+luke-agent[bot]@users.noreply.github.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #3297, from Devin's review there, which came in after it merged.
What was wrong
When an automation's runs were being followed and the automation was deleted (or became unreadable), the next renewal or poll came back not-found.
liveRowsended the follow as gone, butautomation-follow.tscaught that, waited 5 s, and started again. So the page kept showing the old runs for 5 s before it was told not-found.Change
followednow checks whyliveRowsended. OnLIVE_GONEit ends the follow at once:This is the same handling #3276 gave the task list follow.
Checks
compose-automations.test.tspasses (7); typecheck, biome and the repo lint are clean.Made with Luke