Repository navigation
fix(host): an agent archived off a plan the list still holds takes its unread dot with it - #4341
Merged
Merged
Conversation
…s unread dot with it The ledger is fed from the followed task list (#3284), which leaves archived agents out. It forgot an agent only when its whole plan left the list, so an agent archived while its unread dot showed kept the dot. The ledger now also forgets an agent of a held plan that the list no longer names. Co-authored-by: luke-agent[bot] <339870089+luke-agent[bot]@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
…list names it A push of the plans can carry an agents part from before a Start, so the ledger forgets a missing agent only once the followed list had named it. Co-authored-by: luke-agent[bot] <339870089+luke-agent[bot]@users.noreply.github.com>
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
…ew pushes One only a Start answered, then archived before the list named it, would have kept its dot for good. It is now kept through two pushes that leave it out, which covers a push carrying agents from before the Start, and let go on the third. Co-authored-by: luke-agent[bot] <339870089+luke-agent[bot]@users.noreply.github.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #3284, from Devin's review there, which came in after it merged.
What was wrong
Since #3284, the agent ledger is fed from the followed task list. That list leaves archived agents out, but
observeFollowedonly forgot an agent when its whole plan left the list. So archiving an agent while its unread dot was showing left the dot behind. The 30 s watch that #3284 removed used to drop such agents.Change
observeFollowedalso forgets an agent on a plan the list still holds when the list no longer names that agent. Every push of the followed list carries both parts (plans and agents), so the snapshot is never partial.It forgets a missing agent only if an earlier push named it. An agent known only from a Start answer is kept through two pushes in a row that leave it out, because with Realtime on a push of the plans can carry an agents part from before that Start. It's forgotten on the third, as one archived before the list ever named it (both from Devin's review).
Checks
agent-notices.test.ts; the host's notices and client tests pass (58).Made with Luke