Skip to content

perf(panel): an empty toast stack measures nothing on every draw #4324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luke-agent merged 1 commit into from
Oct 21, 2026
Merged

perf(panel): an empty toast stack measures nothing on every draw #4324

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/panel/src/toast.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,6 +401,11 @@ function useStackGlide(): React.RefObject<HTMLOListElement | null> {
useLayoutEffect(() => {
const root = list.current;
if (root === null) return;
// Note that an empty stack, as it stands nearly always, reads nothing: reading the tokens or a box lays out the whole window, and the stack is drawn again with everything around it.
if (root.children.length === 0) {
if (drawn.current.size > 0) drawn.current = new Map();
return;
}
const style = getComputedStyle(root);
const duration = Number.parseFloat(style.getPropertyValue("--duration-fast")) || 0;
const easing = style.getPropertyValue("--spring-fast").trim();
Expand Down
Loading