Repository navigation
feat(panel): one annotation card for review threads, in Files changed and the Conversation - #4203
Merged
Merged
Conversation
… and the Conversation Review threads stand on a shared card (annotation-card.tsx): a one-line head of chevron, the first writer's face and name, age, states, the count while folded, and the ⋯; no lines named and nothing previewed while folded; faces and words each in one column, the head's and every reply's alike. A narrow card (under 440px) drops the age, draws each state as a dot that still names it, counts without the word, and keeps to the pane's inset. A Conversation card, and one above a diff, wear a strip over the head naming the file and lines. The keyboard in a thread lights its lines as the pointer does. Co-authored-by: luke-agent[bot] <339870089+luke-agent[bot]@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: luke-agent[bot] <339870089+luke-agent[bot]@users.noreply.github.com>
…us in a chip's thread lights that thread Co-authored-by: luke-agent[bot] <339870089+luke-agent[bot]@users.noreply.github.com>
5 tasks done
5 tasks done
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is PR 1 of 3 for the approved "Code annotations: one card" design (v3). It moves review threads onto one shared card. PR 2 moves Luke's File-tab notes onto the same card, and PR 3 continues the change band behind it.
AnnotationCard(packages/panel/src/tasks/annotation-card.tsx) is the review thread's quiet card: surface ground, quiet border, 10px corners, width capped atmin(48rem, 100%)..annotation-cardthat the header and the comments both read, so nothing uses a negative-margin offset.L12–13, and pressing it goes to the thread in Files changed. The excerpt and comments follow in the body.Evidence
Screenshots come from a harness that runs the real
AgentPullRequestTabon fixture reads, with the real diff bundle (Pierre plus the highlight worker) and the builtstyles.css. They show before and after at 900px and 360px, in dark and light, plus hover and folded.pnpm check:affected: panel typecheck ran out of memory (exit 137), so I ran the fallback checks below.tsc --noEmitforpackages/panel,apps/desktopandapps/web: clean../scripts/oxlint.sh: 0 warnings, 0 errors.biome check: clean on the changed files.pnpm knip: clean../scripts/repository-checks.sh: passed.vitest(panel): 280 files. 3 failures in the first run came from swapping inmain's sources mid-run for the before shots; the rerun of those files plus the changed ones passed, 349/349.cd apps/desktop && node scripts/build.mjs: bundle budget passes.New tests in
annotation-card.test.ts:In
agent-pull-request-tab.test.ts:src/invite.tsL12–13andsrc/old.tsL9(folded).Test count: +3 tests in a new file.
Screenshots
Invariants
./scripts/check.shgreen. (CI)astype assertion outside the allowlisted files.Effect.runPromise/runSync/runForkoutside the runtime edges.annotation-card.test.ts).agent-pull-request-tab.tsx's header,tasks.css).PRIVACY.mdunchanged.Notes
Made with Luke