Repository navigation
feat(panel): Review stands on a merged or closed pull request, as GitHub takes one - #4200
Merged
Merged
Conversation
…Hub takes one GitHub accepts a review, and review and issue comments, on a pull request that has merged or closed; only a locked conversation refuses them. The tab's Review was held to open and draft pull requests, so it now stands whatever the state, and a refusal says why in GitHub's words as before. The comment box, line comments, replies, resolving and reactions were never held to the state, so they stand already. Co-authored-by: luke-agent[bot] <339870089+luke-agent[bot]@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The developer asked: "Why is the Review button gone when the PR is merged? I think GitHub still allows it, right?" It does. GitHub's API accepts reviews (Comment, Approve, Request changes) and review and issue comments on a merged or closed pull request. Only a locked conversation refuses them, and then only for people without write access.
The only gate on state was Review. I checked every write the tab offers:
If GitHub refuses something, for example Approve on your own PR, or any write on a locked conversation, its words show as today: in the review panel, or on the tab's write note.
Locked conversations: the overview read doesn't carry
lockedoractive_lock_reason, so the tab can't hide these writes ahead of time on a locked PR. Adding it would be a wire and service change: an optional field on the overview answer, read from the same GitHub request, plus the wire snapshots. That would need a Preview run, so it isn't in this PR. Until then, a locked PR offers Review and comments, and GitHub's refusal says why.Follow-up: gate writes on a locked conversation, once the overview read carries
locked. It's left out for now because locked PRs are rare and GitHub's refusal already shows in its words.Screenshots (a merged PR at 900px)
Evidence
agent-pull-request-tab.test.ts: 101 tests pass.tscand./scripts/oxlint.sh: pass.