Repository navigation
refactor(service): retire eve's session stream, which nothing follows any more - #3941
Closed
charleslpan wants to merge 1 commit into
Closed
charleslpan wants to merge 1 commit into
charleslpan wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
luke-agent
Bot
force-pushed
the
luke/voice-brain-realtime
branch
from
October 20, 2026 01:36
3c3120d to
b4ae51f
Compare
luke-agent
Bot
force-pushed
the
luke/retire-eve-session-stream
branch
from
October 20, 2026 01:36
1e518fd to
b101c75
Compare
luke-agent
Bot
force-pushed
the
luke/voice-brain-realtime
branch
from
October 20, 2026 02:06
b4ae51f to
7acfb43
Compare
luke-agent
Bot
force-pushed
the
luke/retire-eve-session-stream
branch
from
October 20, 2026 02:07
b101c75 to
324bddd
Compare
… any more The voice brain was the last follower of `EveSessions.stream`, and it now follows a turn on the task conversation's mark over Neon Realtime. This removes the seam, its NDJSON reader, its two tests, and the empty `stream` on every fake eve. Co-authored-by: luke-agent[bot] <339870089+luke-agent[bot]@users.noreply.github.com>
luke-agent
Bot
force-pushed
the
luke/retire-eve-session-stream
branch
from
October 20, 2026 02:48
324bddd to
ef701bf
Compare
luke-agent
Bot
force-pushed
the
luke/voice-brain-realtime
branch
from
October 20, 2026 02:48
7acfb43 to
4452cf9
Compare
Contributor
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A small follow-up to #3937, stacked on it. The coordinator asked for it.
#3937 moved the voice brain off eve's session stream and onto the task conversation's mark over Neon Realtime. That left
EveSessions.streamwith no caller, so this PR removes it:streammethod onEveSessions, with its reader (streamFromEve,readStreamLine,streamedEvent,EveStreamEvent,STREAM_FROM_TAIL)eve-sessions.test.tstests for that reader, and theirstreamingfixturestreamon every fake eve:coder-host/host.ts's, and those in eight test filesBehaviour doesn't change: nothing read the stream after #3937.
Checks run locally
pnpm check:affectedgets OOM-killed in the sandbox, so I ran its pieces one at a time:repository-checks.sh,biome check .,oxlint,knipdiscarded-effect(with a larger heap)tscfor serviceWhat to check by hand
Nothing: there's no visible change.
Made with Luke