Skip to content

refactor(host,panel): the desktop's held chat read is retired - #3933

Merged
luke-agent[bot] merged 1 commit into
mainfrom
luke/chat-retire-held-read
Oct 21, 2026
Merged

refactor(host,panel): the desktop's held chat read is retired#3933
luke-agent[bot] merged 1 commit into
mainfrom
luke/chat-retire-held-read

Conversation

@charleslpan

@charleslpan charleslpan commented Oct 19, 2026 •
edited by luke-agent Bot
Loading

Copy link
Copy Markdown
Contributor

Part of making workspace chat live over Neon Realtime. It's the top of the chat stack, stacked on #3928. One change: the desktop's held chat read is retired.

Since #3928, nothing asks codingAgents.chat. This PR removes:

  • the act kind, its contract entry and procedure
  • the gateway method
  • the host composer row
  • HostOperator.codingAgentChat
  • the client's chat()
  • codingAgentChatParamsSchema and its golden

The service's held route GET /api/workspaces/chat stays for released desktops.

Tests

The tests that covered only the retired read are removed. The write and follow tests still cover what stays.

Checks run one at a time on the stack's top:

  • tsc for each touched package
  • biome, oxlint, knip, discarded-effect
  • the repository checks
  • the affected vitest suites

@vercel

vercel Bot commented Oct 19, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
luke-web Ready Ready Preview Oct 21, 2026 3:37am UTC

Request Review

@luke-agent
luke-agent Bot force-pushed the luke/chat-live-window branch from 5b6924d to f9c1cb1 Compare October 20, 2026 01:34
@luke-agent
luke-agent Bot force-pushed the luke/chat-retire-held-read branch from 91e8ee3 to 1aee1fc Compare October 20, 2026 01:34
@luke-agent
luke-agent Bot force-pushed the luke/chat-retire-held-read branch from 1aee1fc to 567bfe3 Compare October 20, 2026 01:49
@luke-agent
luke-agent Bot force-pushed the luke/chat-live-window branch from f9c1cb1 to be2396d Compare October 20, 2026 01:50
@luke-agent
luke-agent Bot force-pushed the luke/chat-live-window branch from be2396d to 5b25b22 Compare October 20, 2026 03:08
@luke-agent
luke-agent Bot force-pushed the luke/chat-retire-held-read branch from 567bfe3 to 60bf105 Compare October 20, 2026 03:08
@luke-agent
luke-agent Bot force-pushed the luke/chat-live-window branch from 5b25b22 to 5b9e977 Compare October 20, 2026 22:07
@luke-agent
luke-agent Bot force-pushed the luke/chat-retire-held-read branch from 60bf105 to 05ddf63 Compare October 20, 2026 22:07
@luke-agent luke-agent Bot mentioned this pull request Oct 20, 2026
Merged
@luke-agent luke-agent Bot changed the title refactor(host,desktop): the desktop's held chat read is retired refactor(host,panel): the desktop's held chat read is retired Oct 20, 2026
@luke-agent
luke-agent Bot force-pushed the luke/chat-live-window branch from 5b9e977 to e2e6c26 Compare October 20, 2026 23:29
@luke-agent
luke-agent Bot force-pushed the luke/chat-retire-held-read branch from 05ddf63 to 2ecb691 Compare October 20, 2026 23:29
@luke-agent
luke-agent Bot marked this pull request as ready for review October 20, 2026 23:43
devin-ai-integration[bot]
devin-ai-integration Bot reviewed Oct 20, 2026
View reviewed changes

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@luke-agent
luke-agent Bot force-pushed the luke/chat-retire-held-read branch from 2ecb691 to 6f3b8ca Compare October 21, 2026 00:14
@luke-agent
luke-agent Bot force-pushed the luke/chat-live-window branch from e2e6c26 to 1ffcb98 Compare October 21, 2026 00:14
@luke-agent
luke-agent Bot force-pushed the luke/chat-live-window branch from 1ffcb98 to b54316d Compare October 21, 2026 00:42
@luke-agent
luke-agent Bot force-pushed the luke/chat-retire-held-read branch from 6f3b8ca to 24b6e60 Compare October 21, 2026 00:42
@luke-agent
luke-agent Bot force-pushed the luke/chat-live-window branch from b54316d to d67a50f Compare October 21, 2026 00:52
@luke-agent
luke-agent Bot force-pushed the luke/chat-retire-held-read branch from 24b6e60 to 147893f Compare October 21, 2026 00:52
@luke-agent
luke-agent Bot force-pushed the luke/chat-live-window branch from d67a50f to 322a783 Compare October 21, 2026 01:12
@luke-agent
luke-agent Bot force-pushed the luke/chat-live-window branch from 322a783 to f478684 Compare October 21, 2026 01:52
@luke-agent
luke-agent Bot force-pushed the luke/chat-retire-held-read branch from 91a5892 to 8d1178a Compare October 21, 2026 01:52
@luke-agent
luke-agent Bot force-pushed the luke/chat-live-window branch from f478684 to 690f134 Compare October 21, 2026 02:22
@luke-agent
luke-agent Bot force-pushed the luke/chat-retire-held-read branch from 8d1178a to 9cb8f0a Compare October 21, 2026 02:22
@luke-agent
luke-agent Bot force-pushed the luke/chat-live-window branch from 690f134 to ac96522 Compare October 21, 2026 02:32
@luke-agent
luke-agent Bot force-pushed the luke/chat-retire-held-read branch from 9cb8f0a to 7eb748b Compare October 21, 2026 02:32
@luke-agent
luke-agent Bot force-pushed the luke/chat-retire-held-read branch from 7eb748b to 154dc79 Compare October 21, 2026 02:49
@luke-agent
luke-agent Bot force-pushed the luke/chat-live-window branch from ac96522 to 1bd3521 Compare October 21, 2026 02:49
@luke-agent
luke-agent Bot force-pushed the luke/chat-retire-held-read branch from 154dc79 to 398faeb Compare October 21, 2026 03:23
@luke-agent
luke-agent Bot force-pushed the luke/chat-live-window branch from 1bd3521 to 35d7331 Compare October 21, 2026 03:23
@luke-agent
luke-agent Bot force-pushed the luke/chat-live-window branch from 35d7331 to 7fee8fe Compare October 21, 2026 03:33
@luke-agent
luke-agent Bot force-pushed the luke/chat-retire-held-read branch from 398faeb to ac1932b Compare October 21, 2026 03:33
Base automatically changed from luke/chat-live-window to main October 21, 2026 03:56
@luke-agent luke-agent Bot closed this Oct 21, 2026
@luke-agent
luke-agent Bot force-pushed the luke/chat-retire-held-read branch from ac1932b to 1907c87 Compare October 21, 2026 04:08
@charleslpan @luke-agent
refactor(host,panel): the desktop's held chat read is retired
50c67ea 
The window follows the workspace's chat now, so nothing asks
codingAgents.chat: its act, its gateway method, the host's composer row
and operator call, and the service client's chat() are removed, with
codingAgentChatParamsSchema and its golden. The service's held route
stays for released desktops.

Co-authored-by: luke-agent[bot] <339870089+luke-agent[bot]@users.noreply.github.com>
@luke-agent luke-agent Bot reopened this Oct 21, 2026
@luke-agent
luke-agent Bot added this pull request to the merge queue Oct 21, 2026
Merged via the queue into main with commit 90eef7d Oct 21, 2026
12 checks passed
@luke-agent
luke-agent Bot deleted the luke/chat-retire-held-read branch October 21, 2026 04:37

This branch was successfully deployed

1 active deployment
Preview — 50c67eae Deployed Oct 21, 2026 by vercel[bot]
View deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devin-ai-integration devin-ai-integration[bot] devin-ai-integration[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@charleslpan