Repository navigation
fix(panel): land a revealed thread only where it is placed and seen - #3896
Merged
Merged
Conversation
A thread revealed in Files changed is placed by its file's entry as drawn, once the list holds it, so a picture's threads, and those of a file a filter left out, land above the file as `entryOf` draws them. A landing waits for its card to be visible too, since a panel still arriving refuses the focus. Co-authored-by: luke-agent[bot] <339870089+luke-agent[bot]@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
The landing's test now filters the image out before the jump, which fails without the fix, and asserts the thread stands above the picture rather than reading the entry's lead. Co-authored-by: luke-agent[bot] <339870089+luke-agent[bot]@users.noreply.github.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes two problems Devin raised on #3884 (review-thread deep links). #3884 entered the merge queue and merged before I could push these to it, so they come as a follow-up.
useListLandingworked out the thread's place as soon as the ask came in. If a filter hid the file, it had no entry yet, so it guessed fromfileNoticeand could not tell that a changed image is drawn as its picture.entryOfplaces the thread. A pictured image's threads land above it, with the list scrolled to the file header.[hidden]view. A panel still arriving isvisibility: hidden, which refuses focus, and the landing then ended without it.landablealso requires computed visibility, both by default and in Files changed's in-the-box check, the same thingfocusSeek's staged check waits for.Tests:
visibility: hiddenpanel waits, then rings and focuses the thread once the panel is visible. This fails without the fix.Checks: panel tsc, the PR tab and Files changed suites, and oxlint pass. Desktop/panel only.
Made with Luke