Repository navigation
style(desktop): draw Files changed's unmodified-lines band as one surface - #3833
Merged
Merged
Conversation
…face Pierre filled the band's row with the code's ground and its arrows and words with the band's, so they read as a box pasted onto a strip. The row now takes the band's ground across the card, the arrows and words stand on it with no ground of their own, and only an arrow answers the pointer. Co-authored-by: luke-agent[bot] <339870089+luke-agent[bot]@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
The label stays a target, a bigger one than the arrow: it lets the pointer through to the arrow, whose press now runs the band's width, so it opens the arrow's lines rather than both ends of a gap. Hovering the band lifts the label's ink; the fill stays on the arrow. Co-authored-by: luke-agent[bot] <339870089+luke-agent[bot]@users.noreply.github.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Co-authored-by: luke-agent[bot] <339870089+luke-agent[bot]@users.noreply.github.com>
14 tasks done
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The developer's note: "I don't like how the 'unmodified lines' button has a different background."
Pierre's
line-info-basicseparator draws its wrapper on the code's ground (--diffs-bg), and its arrows and "N unmodified lines" on the band's ground (--diffs-bg-separator), with a 2px code-ground seam after the arrow. The label read as a box pasted onto a strip.LOOK_CSSnow overrides it (as #3818 did for the gutter "+"):--diffs-bg-separator, whichLIST_CSSsets to--luke-color-fill-hoversince style(desktop): Files changed as cards that share one edge, with a quiet fold and a clearer header #3794) across the card's full width.--luke-color-fill-pressed).pointer-events: none) to the arrow, whose press area (::after) now spans the band's width. The label opens exactly the arrow's lines: 20 at a time, or all of a short gap.--luke-color-text-muted.Screenshots
Electron under xvfb, PR #2908's
build.mjs, 900px.Evidence
var()carries a--luke-*fallback, as the checker asks), diff-view and Files changed tests, and the desktop build.Made with Luke