Repository navigation
fix(ui): widen the composer dialog to 720px so New task's foot stands on one row - #3779
Merged
Merged
Conversation
… on one row With a real repository and model named (ReviewStage/luke, Opus 5.5 High Fast), the 620px card wrapped the foot's presses onto a second row. At 720px the foot needs about 585px of its 676px. Co-authored-by: luke-agent[bot] <339870089+luke-agent[bot]@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #3717. With a real repository and model, New task's 620px card pushed the presses at the bottom of the composer (Plan, the model chip, the microphone and Start) onto a second row, and the developer asked for it wider. This PR changes the one token behind
DIALOG_SIZE.COMPOSER,--luke-dialog-composer-width, from 620px to 720px in both profiles. New task is the only dialog using that size.Summary
packages/ui/src/tokens/profiles.css:--luke-dialog-composer-widthgoes from 620px to 720px.min(720px, 100%), and the bottom row still wraps where there's no room.Screenshot
The real
NewTaskDialogin Chromium with fake data, named as on the developer's Mac (ReviewStage/luke, Opus 5.5 High Fast). Everything fits on one row: the controls take about 585px of the 676px available.Evidence
vitest run packages/ui/src/tokens packages/ui/src/components/dialog: 17 passed.Invariants
./scripts/check.shgreen. (CI)PRIVACY.mdunchanged.Notes
Made with Luke