Repository navigation
feat(desktop): group the Issues List by status or by priority - #3696
Merged
Merged
Conversation
View options gains Group by, Status or Priority, while the List stands; the board keeps its status columns. Grouped by priority the List heads the most pressing first and an unweighed issue's last, each listing the work under way first. The choice is kept as Board vs List is, in the renderer's own storage. Co-authored-by: luke-agent[bot] <339870089+luke-agent[bot]@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #3667, from the plan Improve Issues board ("Filter and group"). The orchestrator approved grouping by status or priority for the List only, kept like the other view choices, with no board swimlanes.
What changed
readKept/writeKeptunderluke.issuesGrouping. It is not a synced setting and has no Settings row. Choosing a grouping releases the keyboard from the row the page came back from, as choosing a layout does.ISSUE_GROUPING,IssueGroupingandissueListGroups(issues, grouping)are in@luke/features'issue-list-model.ts.IssueListdraws whatever headings it returns.Tests
issue-list-model.test.ts:issues-page.test.ts: the board offers no Group by. In the List, Group by → Priority heads issues by priority, the choice survives a remount, and Status brings the status headings back. It fails without this change.labelledItemnow prefers an open submenu's item, since "Priority" is both a Group by choice and a filter submenu.Screenshots
From the real components in a browser harness over synthetic issues (dark theme).
No
run.sh --previewMac run is needed: this is renderer-only.Made with Luke