Repository navigation
fix(desktop): draw the folded title bar's offline mark as its buttons draw their glyphs - #3650
Merged
Merged
Conversation
… draw their glyphs On no fill, at the buttons' glyph size, so a heading the folded Inbox centres beside it keeps the gap it keeps beside New task. Co-authored-by: luke-agent[bot] <339870089+luke-agent[bot]@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #3523 from the task "Add UI to show when offline" (https://tryluke.dev/stage/plan/519afac9-0e94-428c-bb83-2afe6908a2d0). The developer reported that the folded title bar looked broken offline, on the Inbox and other pages.
mainby fix(desktop): read the --luke-* roles where CSS still named retired tokens #3631). feat(desktop): say when the Mac is offline #3523 widened--sidebar-toggle-clearanceand sized the title-bar mark with--control-heightand--control-gap. refactor(desktop): remove the desktop's compatibility token aliases #3524 and feat(ui): lift the window-level roles into the shared tokens #3569 had retired those aliases after feat(desktop): say when the Mac is offline #3523's branch was cut, so the override became invalid at computed-value time while offline. The Inbox bar'sgrid-template-columnsthen fell back to implicit auto tracks, and the "Inbox" heading slid under the traffic lights and the sidebar toggle. Every other folded toolbar lost its clearance the same way. fix(desktop): read the --luke-* roles where CSS still named retired tokens #3631 renamed those reads to--luke-control-heightand--luke-control-gapand added the repository check that refuses a read nothing declares. A build from before fix(desktop): read the --luke-* roles where CSS still named retired tokens #3631 still shows the bug.--luke-control-icon, one button wide. A heading next to it keeps the same gap it keeps next to New task when online. The pill in the sidebar's foot and on the sign-in screen is unchanged.Evidence
dist/renderer/styles.cssand a copy of the folded Inbox bar's DOM (318px list):--control-*), offline: the heading starts at 70.6px and the grid falls back to56.6px 95.8px 124.6px. This reproduces the screenshot.main, offline: the heading starts at 179px, right after the cluster, which ends at 177px. Online it is 149 after 147.scripts/repository-checks.sh✅ (including the undeclared-property check from fix(desktop): read the --luke-* roles where CSS still named retired tokens #3631),biome check✅. CSS only.Invariants
./scripts/check.shgreen. (CI)desktop-shell.test.tsalready covers the mark standing in the folded title bar, and jsdom computes no layout.astype assertion.Effect.runPromise/runSync/runForkoutside the runtime edges.CLAUDE.md/AGENTS.mdsentence names a changed part.PRIVACY.mdunchanged.Notes
Made with Luke
Summary by cubic
Fixes the folded title bar's offline mark so it draws like the buttons beside it.
The mark was a tinted 30px circle sitting 2px off the "Inbox" heading, which looked cramped. It now draws the amber glyph on no fill, at
--luke-control-iconsize and one button wide, keeping the same gap a heading keeps beside New task when online. The pill in the sidebar's foot and on the sign-in screen is unchanged.Written for commit 70eb859. Summary will update on new commits.