Repository navigation
fix(desktop): draw the Issues board and an issue's page in blocks while they read - #3632
Merged
Merged
Conversation
…le they read The board stood nothing under its toolbar until the list answered, and an issue opened from a link stood only its breadcrumbs until its read did. The board now stands a column of blocks for every status, in the board's own geometry, and an issue's page its title, byline, chips, and a few description lines as blocks in its own document, each said as reading. Co-authored-by: luke-agent[bot] <339870089+luke-agent[bot]@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Summary
PR 7 of 9 in the loading-states rollout (Issues). Context: the Loading states audit and the plan Fix Inbox loading state, "Loading states rollout".
CollectionPage's loading rows are shaped like a list, not a board. It now drawsIssueBoardSkeleton(issue-board.tsx), one column per status in the board's own.issue-board/.issue-columnbox. Each column has a head block where the glyph and name go, and a few cards, each with an identifier-and-time line over a title line. The whole thing sits in aSkeletonRegionthat says "Reading issues". The list layout keepsCollectionPage's loading rows. I updated thelistStatecomment to match.useIssueanswered.DetailFramenow drawsIssueDetailSkeleton(issue-detail.tsx) in the issue's own.desktop-document/.plan-body: a title block in the heading's type, a byline block, two chip-sized control blocks, and three description lines, said as "Reading the issue". The failure states are unchanged.@luke/ui'sSkeleton,SKELETON_SHAPE, andSkeletonRegion.styles/issues.cssuses only tokens and adds a few rules so the reading region fills the page's height, as the board does.Evidence
pnpm check:affectedpassed: typecheck; lint, knip, discarded-effect; and test (desktop 213 files, 1969 tests).desktop/issues-page.test.tsfail without the change:Invariants
./scripts/check.shgreen. (CI)LUKE_UPDATE_FIXTURESnot run, or diff explained line by line). (CI)AGENTS.md"Testing")astype assertion outside the allowlisted files. (CI via anti-slop)Effect.runPromise/runSync/runForkoutside the runtime edges and the shimstools/anti-slop/effect-edges.jsonrecords. (CI viaanti-slop/no-run-promise-outside-edges)setTimeout/setInterval/new Promise/AbortController/fs.watchoutside the filestools/anti-slop/effect-edges.jsonrecords. (CI viaanti-slop/no-raw-async-primitives)pnpm discarded-effect)AGENTS.md's "The permanent adaptors" with the reason it stays.CLAUDE.md/AGENTS.mdsentence naming a changed part is edited; root pair stays byte-identical. (CI for pair existence; manual for wording)PRIVACY.mdunchanged, or the change is a product decision called out in the PR body.package.jsondeps match what the sources import by bare specifier;effectviacatalog:. (CI)@effect/platform-node,effect/sql) behind a barrel the renderer or a web function opens. (CI: existing renderernode:grep plus a new grep for those specifiers in renderer bundles)Notes
Made with Luke
Summary by cubic
Adds loading skeletons so the Issues board and an individual issue's page show placeholders shaped like their content while data is read, instead of drawing nothing.
desktop/issues-page.test.tscover both reading states.Written for commit 09d3f1c. Summary will update on new commits.