Repository navigation
fix(host): send an inbox answer's files to the service - #3475
Merged
Merged
Conversation
The host operator forwarded an answer's reply, choices, values, note, and key to the gateway but left its attachments out, so files attached to an answer never reached the service. Co-authored-by: luke-agent[bot] <339870089+luke-agent[bot]@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
codingAgentInboxAnswerinpackages/host/src/host-operator.tssent the answer's reply, choices, values, note, and key to the gateway, but left out itsattachments, so the composer dropped them before they reachedHostedCodingAgentClient.answerInbox. It now sends them whenever the answer has any.host-operator.test.ts: an answer with a file reaches the gateway call with the file included. It fails without the fix.Found while building the desktop half of Inbox thread messages (stacked on #3469). Split out off
mainso it lands right away.Evidence
pnpm check:affectedpasses exceptsrc/main/app-menu.test.ts, which fails only because the sandbox has no Electron binary.Invariants
./scripts/check.shgreen. (CI)LUKE_UPDATE_FIXTURESnot run, or diff explained line by line). (CI)AGENTS.md"Testing")astype assertion outside the allowlisted files. (CI via anti-slop)Effect.runPromise/runSync/runForkoutside the runtime edges and the shimstools/anti-slop/effect-edges.jsonrecords. (CI viaanti-slop/no-run-promise-outside-edges)setTimeout/setInterval/new Promise/AbortController/fs.watchoutside the filestools/anti-slop/effect-edges.jsonrecords. (CI viaanti-slop/no-raw-async-primitives)pnpm discarded-effect)host-operator.test.ts)AGENTS.md's "The permanent adaptors" with the reason it stays.CLAUDE.md/AGENTS.mdsentence naming a changed part is edited; root pair stays byte-identical. (CI for pair existence; manual for wording)PRIVACY.mdunchanged, or the change is a product decision called out in the PR body.package.jsondeps match what the sources import by bare specifier;effectviacatalog:. (CI)@effect/platform-node,effect/sql) behind a barrel the renderer or a web function opens. (CI: existing renderernode:grep plus a new grep for those specifiers in renderer bundles)Notes
Made with Luke
Summary by cubic
Fixes inbox answer attachments never reaching the service. The host operator now forwards an answer's
attachmentsto the gateway, so files attached to an answer arrive with its reply, note, and choices.Written for commit 18084f1. Summary will update on new commits.