fix GXS infinite reload of unprocessed items at startup#260
Merged
csoler merged 2 commits intoRetroShare:masterfrom Feb 13, 2026
Merged
fix GXS infinite reload of unprocessed items at startup#260csoler merged 2 commits intoRetroShare:masterfrom
csoler merged 2 commits intoRetroShare:masterfrom
Conversation
0de2ada to
9cce5bb
Compare
csoler
reviewed
Feb 11, 2026
src/gxs/rsgxsdataaccess.cc
Outdated
| << " MsgStatus: " << meta->mMsgStatus | ||
| << " MsgId: " << meta->mMsgId << std::endl; | ||
| #endif | ||
| return true; |
Contributor
There was a problem hiding this comment.
Why this return? It blocks the checking of other flags below as it did before.
csoler
reviewed
Feb 11, 2026
Contributor
csoler
left a comment
There was a problem hiding this comment.
good catch. One issue to answer/fix.
5660fe3 to
1fa478b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
GXS Channels service was experiencing a massive CPU and memory spike at every startup. Thousands of "Unprocessed" items were being reloaded in an infinite loop because they were never successfully acknowledged and persisted as "Processed" in the database.
Root Causes
UNPROCESSEDstate forever.RsGxsDataAccess::getMsgIdList, if a filter resulted in zero matches, it returned an empty ID set. The lower-level DB layer interpreted an empty set as "fetch everything," effectively bypassing the filter and reloading already-processed items.Proposed Changes
protectedvisibility to allow services to force DB synchronization.Impact