Recognize SCPH5552 outputs and retain its SDK inputs - #5
Open
Alexbeav wants to merge 1 commit into
Open
Conversation
Collaborator
|
I don't know that we have 5552 support yet, and it needs handling in the generate & build and netplay lobby, and settings window for rebuild prompts, as well so I'll just leave this open for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SCPH5552 titles can finish generation and then stop because both build-readiness checks recognize only OpenBIOS and SCPH1001 output. The shared SDK harvest also drops the SCPH5552 profile and seed file. This change recognizes the existing backend and retains those two source inputs, while keeping the owned BIOS image out of the shared SDK.
Validation against unchanged upstream
99e0238f53356b63d966d9dfe6f0abaacc578d17:Run the synthetic check with
python scripts/test_psx_bios_readiness.py --cxx g++. Add--baseline-ref 99e0238f53356b63d966d9dfe6f0abaacc578d17for the failing control. The fixtures contain no retail data. The patch preserves the title's selected BIOS policy.Developed with AI assistance; validated as described (test evidence in PR body). AI writes the code and the PR, but I always test before I send something up. Happy to iterate on this process with your feedback.