Skip to content

Add "growing color" animation for active pipeline categories#24

Open
Resmung0 wants to merge 2 commits into
masterfrom
feature/pipeline-running-animation-2063333807896213844
Open

Add "growing color" animation for active pipeline categories#24
Resmung0 wants to merge 2 commits into
masterfrom
feature/pipeline-running-animation-2063333807896213844

Conversation

@Resmung0

@Resmung0 Resmung0 commented May 9, 2026

Copy link
Copy Markdown
Owner

This change adds a new animation to the TopPanel component in the webview. When a pipeline is running, the active category tab will now show its specific color growing from 0% to 100% width, providing a clear visual indication of progress.

Key changes:

  • Modified TopPanel.tsx to include category-specific colors and a framer-motion animation.
  • Updated PipelineCanvas.tsx to pass the isRunning state to TopPanel.
  • Verified the animation visually using Playwright and ensured all unit tests pass.

PR created automatically by Jules for task 2063333807896213844 started by @Resmung0

Summary by Sourcery

Add a visual running-state indicator to the pipeline top panel by animating the active category tab with its category color when a pipeline is running.

New Features:

  • Show a category-colored animated fill on the active pipeline tab while a pipeline is running.

Enhancements:

  • Propagate the pipeline running state into the top panel to drive the new visual indicator.

…gories

Co-authored-by: Resmung0 <36093882+Resmung0@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@sourcery-ai

sourcery-ai Bot commented May 9, 2026

Copy link
Copy Markdown

Reviewer's Guide

Implements a category-colored "growing" run animation on the active tab in TopPanel using framer-motion, wiring the pipeline running state from PipelineCanvas into the TopPanel and adding the necessary styling and props.

Sequence diagram for passing isRunning to TopPanel and triggering the growing color animation

sequenceDiagram
    actor User
    participant PipelineCanvas
    participant TopPanel
    participant FramerMotion

    User->>PipelineCanvas: Start pipeline run
    PipelineCanvas->>PipelineCanvas: set isRunning = true
    PipelineCanvas->>TopPanel: render TopPanel(onCategorySelect, activeCategory, isRunning=true)
    TopPanel->>TopPanel: determine isActive for each context
    TopPanel->>FramerMotion: AnimatePresence + motion.div for active tab when isRunning
    FramerMotion-->>TopPanel: Animate width 0% -> 100% (repeat Infinity)
    TopPanel-->>User: Show active tab with growing category color fill

    User->>PipelineCanvas: Pipeline run completes
    PipelineCanvas->>PipelineCanvas: set isRunning = false
    PipelineCanvas->>TopPanel: render TopPanel(onCategorySelect, activeCategory, isRunning=false)
    TopPanel->>FramerMotion: AnimatePresence exit for run-fill
    FramerMotion-->>TopPanel: Stop animation and remove run-fill
    TopPanel-->>User: Show active tab without growing color fill
Loading

Class diagram for updated PipelineCanvas and TopPanel props

classDiagram
    class PipelineCanvas {
      +string activeCategory
      +boolean isRunning
      +handleCategorySelect(category)
      +render()
    }

    class TopPanelProps {
      +function onCategorySelect(category)
      +string activeCategory
      +boolean isRunning
    }

    class TopPanel {
      +TopPanelProps props
      +string activeContext
      +contexts: array
      +render()
    }

    PipelineCanvas --> TopPanel : renders
    TopPanel --> TopPanelProps : uses
Loading

File-Level Changes

Change Details Files
Add a framer-motion driven animated fill bar to the active, running category tab in TopPanel.
  • Imported motion and AnimatePresence from framer-motion into TopPanel component.
  • Extended context definitions to include a hex color per category and expose it as a CSS variable on each tab.
  • Rendered a motion.div as a background fill for the active tab when the pipeline is running, animating its width from 0% to 100% on an infinite linear loop.
  • Adjusted icon and label styling/z-index so they render above the animated background fill.
  • Updated tab CSS to hide overflow and style the animated run-fill element.
src/webview/components/TopPanel.tsx
Propagate pipeline running state into TopPanel so the animation is only active while the pipeline is running.
  • Extended TopPanelProps with an optional isRunning flag and defaulted it to false in the component signature.
  • Passed isRunning from PipelineCanvas into every TopPanel usage, including empty and waiting states.
src/webview/components/TopPanel.tsx
src/webview/PipelineCanvas.tsx

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The new z-index/position styling for the icon and label is duplicated inline; consider moving these to CSS classes to keep styling centralized and easier to adjust later.
  • Since TopPanel is now tightly coupled to the running state, you might make isRunning a required prop instead of optional to better reflect the component’s expected usage and avoid silent fallbacks.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The new z-index/position styling for the icon and label is duplicated inline; consider moving these to CSS classes to keep styling centralized and easier to adjust later.
- Since `TopPanel` is now tightly coupled to the running state, you might make `isRunning` a required prop instead of optional to better reflect the component’s expected usage and avoid silent fallbacks.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

…gories

- Added a `framer-motion` animation in `TopPanel` that fills the active category tab with its specific color when a pipeline is running.
- Category colors: CI/CD (#10B981), Data Processing (#8B5CF6), AI Agent (#EC4899), RPA (#EF4444).
- Refactored `TopPanel` to use a `.tab-content` CSS class for better styling organization.
- Made `isRunning` a required prop in `TopPanel`.
- Updated `PipelineCanvas` to pass `isRunning` state to `TopPanel`.

Co-authored-by: Resmung0 <36093882+Resmung0@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant