Add "growing color" animation for active pipeline categories#24
Add "growing color" animation for active pipeline categories#24Resmung0 wants to merge 2 commits into
Conversation
…gories Co-authored-by: Resmung0 <36093882+Resmung0@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Reviewer's GuideImplements a category-colored "growing" run animation on the active tab in TopPanel using framer-motion, wiring the pipeline running state from PipelineCanvas into the TopPanel and adding the necessary styling and props. Sequence diagram for passing isRunning to TopPanel and triggering the growing color animationsequenceDiagram
actor User
participant PipelineCanvas
participant TopPanel
participant FramerMotion
User->>PipelineCanvas: Start pipeline run
PipelineCanvas->>PipelineCanvas: set isRunning = true
PipelineCanvas->>TopPanel: render TopPanel(onCategorySelect, activeCategory, isRunning=true)
TopPanel->>TopPanel: determine isActive for each context
TopPanel->>FramerMotion: AnimatePresence + motion.div for active tab when isRunning
FramerMotion-->>TopPanel: Animate width 0% -> 100% (repeat Infinity)
TopPanel-->>User: Show active tab with growing category color fill
User->>PipelineCanvas: Pipeline run completes
PipelineCanvas->>PipelineCanvas: set isRunning = false
PipelineCanvas->>TopPanel: render TopPanel(onCategorySelect, activeCategory, isRunning=false)
TopPanel->>FramerMotion: AnimatePresence exit for run-fill
FramerMotion-->>TopPanel: Stop animation and remove run-fill
TopPanel-->>User: Show active tab without growing color fill
Class diagram for updated PipelineCanvas and TopPanel propsclassDiagram
class PipelineCanvas {
+string activeCategory
+boolean isRunning
+handleCategorySelect(category)
+render()
}
class TopPanelProps {
+function onCategorySelect(category)
+string activeCategory
+boolean isRunning
}
class TopPanel {
+TopPanelProps props
+string activeContext
+contexts: array
+render()
}
PipelineCanvas --> TopPanel : renders
TopPanel --> TopPanelProps : uses
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The new z-index/position styling for the icon and label is duplicated inline; consider moving these to CSS classes to keep styling centralized and easier to adjust later.
- Since
TopPanelis now tightly coupled to the running state, you might makeisRunninga required prop instead of optional to better reflect the component’s expected usage and avoid silent fallbacks.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The new z-index/position styling for the icon and label is duplicated inline; consider moving these to CSS classes to keep styling centralized and easier to adjust later.
- Since `TopPanel` is now tightly coupled to the running state, you might make `isRunning` a required prop instead of optional to better reflect the component’s expected usage and avoid silent fallbacks.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
…gories - Added a `framer-motion` animation in `TopPanel` that fills the active category tab with its specific color when a pipeline is running. - Category colors: CI/CD (#10B981), Data Processing (#8B5CF6), AI Agent (#EC4899), RPA (#EF4444). - Refactored `TopPanel` to use a `.tab-content` CSS class for better styling organization. - Made `isRunning` a required prop in `TopPanel`. - Updated `PipelineCanvas` to pass `isRunning` state to `TopPanel`. Co-authored-by: Resmung0 <36093882+Resmung0@users.noreply.github.com>
This change adds a new animation to the TopPanel component in the webview. When a pipeline is running, the active category tab will now show its specific color growing from 0% to 100% width, providing a clear visual indication of progress.
Key changes:
PR created automatically by Jules for task 2063333807896213844 started by @Resmung0
Summary by Sourcery
Add a visual running-state indicator to the pipeline top panel by animating the active category tab with its category color when a pipeline is running.
New Features:
Enhancements: