Skip to content

chore(deps): complete jsdom 30 upgrade - #95

Closed
dependabot[bot] wants to merge 3 commits into
mainfrom
dependabot/npm_and_yarn/frontend/jsdom-30.0.1
Closed

chore(deps): complete jsdom 30 upgrade#95
dependabot[bot] wants to merge 3 commits into
mainfrom
dependabot/npm_and_yarn/frontend/jsdom-30.0.1

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Aug 3, 2026

Copy link
Copy Markdown
Contributor

Bumps jsdom from 26.1.0 to 30.0.1 and completes the required test compatibility work.

Changes

  • refresh the root pnpm lockfile so CI installs jsdom 30 rather than the stale root resolution
  • update the workflow editor test selector to search below the mounted root element, matching jsdom 30's standards-compliant Element.querySelector behavior

Verification

  • Node 24.18.0 / pnpm 9.12.3 frozen install
  • targeted workflow editor tests: 4 passed
  • full frontend suite: 172 files / 960 tests passed
  • lint passed
  • typecheck passed
  • production build passed

Merge dependencies

Both must merge before this PR is refreshed and receives its final merge decision.

Bumps [jsdom](https://github.com/jsdom/jsdom) from 26.1.0 to 30.0.1.
- [Release notes](https://github.com/jsdom/jsdom/releases)
- [Commits](jsdom/jsdom@v26.1.0...v30.0.1)

---
updated-dependencies:
- dependency-name: jsdom
  dependency-version: 30.0.1
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code labels Aug 3, 2026

@Isaries Isaries left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-review: scope is the complete frontend/package.json diff for jsdom 30.0.1 plus official package metadata and CI configuration. Blockers: the PR omits the root pnpm-lock.yaml, and jsdom 30.0.1 requires Node ^22.22.2, ^24.15.0, or >=26 while CI is configured for Node 20. The update therefore cannot be validated or supported on the current toolchain. Decision: changes required; first move CI and the frontend build image to a supported LTS Node line, then regenerate the root lockfile and run the full frontend suite.

@Isaries Isaries changed the title deps(frontend): bump jsdom from 26.1.0 to 30.0.1 in /frontend chore(deps): complete jsdom 30 upgrade Aug 6, 2026
@Isaries

Isaries commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Superseded by #110, which bumps jsdom to 30.0.1 with the root pnpm-lock.yaml update this PR was missing. The lockfile gap was a Dependabot configuration defect, fixed in #100. The Node engine constraint noted in review still applies and is tracked in #98.

@Isaries Isaries closed this Aug 6, 2026
@dependabot @github

dependabot Bot commented on behalf of github Aug 6, 2026

Copy link
Copy Markdown
Contributor Author

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot
dependabot Bot deleted the dependabot/npm_and_yarn/frontend/jsdom-30.0.1 branch August 6, 2026 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant